Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AndroidCrypto] Support a zero-length salt for HMACs. #49384

Merged
merged 2 commits into from
Mar 10, 2021
Merged

[AndroidCrypto] Support a zero-length salt for HMACs. #49384

merged 2 commits into from
Mar 10, 2021
+16 −2

Commits on Mar 9, 2021

  1. [AndroidCrypto] Support a zero-length salt for HMACs. 

    Java does not support zero-length arrays in the SecretKeySpec constructor, so instead use a zero-initialized one-byte array as the key when zero bytes are provided.

This fixes the failing HKDF tests, so about 40ish more tests pass with this fix.
    @jkoritzinsky
    jkoritzinsky committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    37173e4 View commit details
    Browse the repository at this point in the history

  2. Update src/libraries/Native/Unix/System.Security.Cryptography.Native.… 

    …Android/pal_hmac.c
    @jkoritzinsky
    jkoritzinsky committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    47ab0a8 View commit details
    Browse the repository at this point in the history