Fix swapped args in AssemblySpec::AssemblyNameInit

[omajid]

GetPEKindAndMachine takes two arguments, a kind and a machine, in that order:

$ ag GetPEKindAndMachine
...
src/coreclr/vm/pefile.cpp
181:    peFile->GetPEKindAndMachine(&peKind, &actualMachineType);
1688:void PEFile::GetPEKindAndMachine(DWORD* pdwKind, DWORD* pdwMachine)
1723:    GetILimage()->GetPEKindAndMachine(pdwKind, pdwMachine);

src/coreclr/vm/peimage.h
383:    void GetPEKindAndMachine(DWORD* pdwKind, DWORD* pdwMachine);
...

But this code swaps the arguments:

pImageInfo->GetPEKindAndMachine(&dwMachine,&dwKind);

Fix that.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @vitek-karas, @agocke, @CoffeeFlux, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

---

GetPEKindAndMachine takes two arguments, a kind and a machine, in that order:

$ ag GetPEKindAndMachine
...
src/coreclr/vm/pefile.cpp
181:    peFile->GetPEKindAndMachine(&peKind, &actualMachineType);
1688:void PEFile::GetPEKindAndMachine(DWORD* pdwKind, DWORD* pdwMachine)
1723:    GetILimage()->GetPEKindAndMachine(pdwKind, pdwMachine);

src/coreclr/vm/peimage.h
383:    void GetPEKindAndMachine(DWORD* pdwKind, DWORD* pdwMachine);
...

But this code swaps the arguments:

pImageInfo->GetPEKindAndMachine(&dwMachine,&dwKind);

Fix that.

Author:	omajid
Assignees:	-
Labels:	area-AssemblyLoader-coreclr, area-VM-coreclr
Milestone:	-

[vitek-karas]

The names of the local variables are swapped, but they're also swapped below when used to call the AssemblyName.SetProcArchIndex. So in the end the right values are passed in. It would be great if you could simply swap the variables in both places so that the names match the meaning.

This also means that there's no test for this (it should have failed with your change). It would be great if you could add a test for this. Probably somewhere around here: https://github.com/dotnet/runtime/tree/main/src/tests/Loader/binding/assemblies/basicapi/assemblynamector

[omajid]

Thanks. Great to know that this isn't an actual bug. I am blocked by #50175 for a test. Once I have that sorted out, I will update this PR.

[agocke]

@omajid Any update? Sorry, you may have to use Ubuntu (or an Ubuntu docker image) since we don't have an officially supported Fedora workflow.

[omajid]

Sorry, didn't get a chance to look into this any further. I will try and find some time this week.

[agocke]

No worries -- if you want to close this PR and come back to it later when you have time, we'll be happy to help then.

[agocke]

Closing for now to clean up queries. Feel free to re-open when the changes are ready