Disable Net5CompatFileStream by default #50166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
added
the
NO-MERGE
stephentoub
reviewed
Mar 24, 2021
src/libraries/System.IO.FileSystem/tests/LegacyTests/LegacySwitchTests.cs
Outdated
Show resolved
Hide resolved
Merged
adamsitnik
force-pushed
the
disableLegacyFileStream
branch
from
13bc74e
to
ae9db76
Compare
Jozkee
reviewed
Mar 31, 2021
src/libraries/System.Private.CoreLib/src/System/IO/Strategies/FileStreamHelpers.cs
Outdated
Show resolved
Hide resolved
…ream # Conflicts: # src/libraries/System.IO.FileSystem/tests/Net5CompatTests/Net5CompatSwitchTests.cs # src/libraries/System.Private.CoreLib/src/System/IO/Strategies/FileStreamHelpers.cs
|
/azp run runtime-libraries-coreclr outerloop-windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adamsitnik
added
the
breaking-change
ghost
added
the
needs-breaking-change-doc-created
adamsitnik
removed
the
NO-MERGE
adamsitnik
changed the title
|
@carlossanlop @Jozkee @stephentoub everything is ready (please see the PR description for full details), PTAL |
|
/azp run runtime-libraries-coreclr outerloop-windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
reviewed
Apr 7, 2021
src/libraries/System.Private.CoreLib/src/System/IO/Strategies/FileStreamHelpers.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Apr 7, 2021
Jozkee
approved these changes
Apr 7, 2021
This was referenced Apr 7, 2021
This was referenced Apr 9, 2021
[NO MERGE] use a hacky way to run all the tests using new FileStream implementation
dotnet/sdk#16684
Closed
carlossanlop
added a commit
to carlossanlop/runtime
that referenced
this pull request
Apr 12, 2021
This reverts commit 8b2ad5b to unblock dotnet/sdk.
ghost
locked as resolved and limited conversation to collaborators
|
Breaking change doc: dotnet/docs#24060 |
adamsitnik
removed
the
needs-breaking-change-doc-created
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LegacytoNet5Compat([FileStream] Rename "Legacy" to "Net5Compat" #50470)