Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up REGUTIL/CLRConfig system #50314

Merged
merged 5 commits into from
Mar 29, 2021

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Mar 27, 2021

Convert all configuration options to use CLRConfig that still rely directly on REGUTIL.
Limit all uses of the REGUTIL code to the CLRConfig implementation.

Contributes toward #47283

Next PR is to remove Registry logic from REGUTIL and fold remaining implementation into CLRConfig.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc build needs a bit of work. LGTM otherwise.

@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review March 27, 2021 16:27
@AaronRobinsonMSFT AaronRobinsonMSFT merged commit d261384 into dotnet:main Mar 29, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the isolate_regutil branch March 29, 2021 20:58
@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants