Add ExceptionDispatchInfo.SetRemoteStackTrace #50392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Oh no what did I break? :( |
jkotas
reviewed
Mar 30, 2021
...braries/System.Private.CoreLib/src/System/Runtime/ExceptionServices/ExceptionDispatchInfo.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Mar 30, 2021
src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Mar 30, 2021
src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Mar 30, 2021
- Share more code across coreclr + mono
|
Opened #50520 to track the crossgen2 test failures. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50044.
The approved API (see #50044 (comment)) returns
bool, which is clearly a mistake given that we wanted to make it a non-try method just like its sibling SetCurrentStackTrace. So for this PR, I made the method returnException, just like its sibling. I believe this follows the spirit of what the API review intended.It's too difficult for me to test the "immutable agile exception" case, so I didn't. That's going to have to remain within the purview of code review.
Also took this time to do some minor cleanup of existing devdoc and unit tests. Nothing too fancy.
/cc @ReubenBond