Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge REGUTIL logic for environment variables into CLRConfig #50393

Merged
merged 5 commits into from
Mar 31, 2021
Merged

Merge REGUTIL logic for environment variables into CLRConfig #50393

merged 5 commits into from
Mar 31, 2021

Conversation

AaronRobinsonMSFT
Copy link
Member

Remove REGUTIL.
Remove unused CLR configuration options.

Contributes toward #47283

Next PR is to add reading of DOTNET_ prefix.

@AaronRobinsonMSFT
Merge REGUTIL logic for environment variables into CLRConfig
9838730 
Remove REGUTIL
Remove unused CLR configuration options
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 6.0.0 milestone Mar 29, 2021
jkotas
jkotas approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/coreclr/inc/utilcode.h Outdated Show resolved Hide resolved
src/coreclr/utilcode/clrconfig.cpp Show resolved Hide resolved
stephentoub
stephentoub approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AaronRobinsonMSFT
Copy link
Member Author

@sdmaclea @janvorli Do either of you have any suggestions on how I can investigate the ARM64 fails above? It appears they are for crossgen2 and I've no idea why this change would have impacted them but they keep failing. Trying to download binaries and run them on an M1 is basically folly because it keeps tell me they are potentially malicious and can't be validated. Suggestions are most welcome.

@AaronRobinsonMSFT
Copy link
Member Author

I do not observe this failure locally.

@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request Mar 31, 2021
Closed
@AaronRobinsonMSFT
Copy link
Member Author

Failure is unrelated. Issue filed #50466.

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 99d6215 into dotnet:main Mar 31, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the merge_regutil_into_clrconfig branch March 31, 2021 03:51
@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
area-VM-coreclr
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AaronRobinsonMSFT @stephentoub @jkotas