Use OptimizeForSize condition in SPC only on Browser #50413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was only set for Browser/tvOS before.
akoeplinger
force-pushed
the
size-optimize
branch
from
5915e66
to
309b255
Compare
|
See also #49372 for some of the rationale for this. |
|
From @jkotas' comment on that PR:
I don't know what the size penalty is but we should definitely be consistent between iOS and tvOS, so maybe we'll need the size optimized version only for Browser. |
I think it was 2KB compressed and 6KB raw - for IL. See #48006 (comment). |
akoeplinger
changed the title
|
Ok thanks, I think that's negligible for mobile so I switched the condition to only apply to Browser. |
jkotas
approved these changes
Mar 30, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size impact doesn't matter for tvOS.