Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mono runtime component infrastructure including EventPipe/DiagnosticsServer as a Mono runtime component. #50837

Merged
merged 55 commits into from
Apr 20, 2021
Merged

Mono runtime component infrastructure including EventPipe/DiagnosticsServer as a Mono runtime component. #50837

merged 55 commits into from
Apr 20, 2021

Conversation

lateralusX
Copy link
Member

@lateralusX lateralusX commented Apr 7, 2021 •
edited
Loading

Implementation of Mono runtime component infrastructure initial worked on in draft PR, #49913. This PR replace that work but documentation (https://github.com/dotnet/runtime/blob/af8e756e2dd6a858066a8de61d569a4abe749284/docs/design/mono/components.md) is still left in that PR and will probably be moved to separate PR and merged.

This PR also includes a port of Mono EventPipe/DiagnosticsServer library over to new runtime component infrastructure.

Before all packaging/deploy have been fixed for platforms that will switch over to hosting components as shared libraries, all components will be build and linked using the static linkage scenario outline in document above. Once package and deploy is resolved for dynamic linking scenarios, we will switch this for corresponding platforms in separate PR.

@lambdageek @akoeplinger @steveisok

@lateralusX lateralusX changed the title WIP: Mono component infrastructure including EventPipe/DiagnosticsServer as Mono component. WIP: Mono component infrastructure including EventPipe/DiagnosticsServer as a Mono component. Apr 7, 2021
@ghost
Copy link

ghost commented Apr 7, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Implementation of Mono component infrastructure initial worked on in draft PR, #49913. This PR replace that work but documentation (https://github.com/dotnet/runtime/blob/af8e756e2dd6a858066a8de61d569a4abe749284/docs/design/mono/components.md) is still left in that PR and will probably be moved to separate PR.

This PR also includes a port of Mono EventPipe/DiagnosticsServer library over to new component infrastructure.

Before all packaging/deploy have been fixed for platforms that will switch over to hosting components as shared libraries, all components will be build and linked using the static linkage scenario outline in document above. Once package and deploy is resolved for dynamic linking scenarios, we will switch this for corresponding platforms in separate PR.

@lambdageek @akoeplinger @steveisok

Author: lateralusX
Assignees: -
Labels:

area-Build-mono, area-Infrastructure-mono
Milestone: -

@ghost ghost added this to In Progress in Infrastructure Backlog Apr 7, 2021
@lateralusX lateralusX changed the title WIP: Mono component infrastructure including EventPipe/DiagnosticsServer as a Mono component. WIP: Mono runtime component infrastructure including EventPipe/DiagnosticsServer as a Mono runtime component. Apr 7, 2021
This was referenced Apr 7, 2021
Closed
Merged
This was referenced Apr 8, 2021
Closed
Closed
Closed
@lambdageek lambdageek mentioned this pull request Apr 9, 2021
Closed
@lateralusX lateralusX force-pushed the lateralusX/eventpipe-as-component branch from be59f74 to 4d7078c Compare April 15, 2021 11:58
@runfoapp runfoapp bot mentioned this pull request Apr 15, 2021
Closed
@lateralusX lateralusX changed the title WIP: Mono runtime component infrastructure including EventPipe/DiagnosticsServer as a Mono runtime component. Mono runtime component infrastructure including EventPipe/DiagnosticsServer as a Mono runtime component. Apr 15, 2021
@lateralusX lateralusX marked this pull request as ready for review April 15, 2021 17:37
lambdageek
lambdageek reviewed Apr 15, 2021
View reviewed changes
src/mono/mono.proj Outdated Show resolved Hide resolved
thaystg
thaystg reviewed Apr 15, 2021
View reviewed changes
src/mono/mono.proj Outdated Show resolved Hide resolved
thaystg
thaystg reviewed Apr 15, 2021
View reviewed changes
src/mono/mono.proj Outdated Show resolved Hide resolved
thaystg
thaystg reviewed Apr 15, 2021
View reviewed changes
src/mono/mono.proj Outdated Show resolved Hide resolved
lateralusX and others added 22 commits April 19, 2021 13:26
@lateralusX
Use static components and disable TCP/IP.
73738a8
@lateralusX
Cleanup after rebase/merge.
dd59777
@lateralusX
Removed components.md.
e730fdd
@lateralusX
Only build mono dac shared library on Windows x64 and don't install.
be1778a
@lateralusX
Split static and shared lib names.
853dd85
@lateralusX
Add component artifacts to installer pkg.
e9238e3
@lateralusX
Make owning_thread_id a little less racy on EP_CHECKED_BUILD.
cf6710e
@lateralusX
Emit EEStartupStart event on Mono runtime.
7eba3c4
@lateralusX
Fix DISABLE_COMPONENTS to included needed stubs in monosgen-2.0 stati…
b74160c 
…c lib.
@lateralusX
Switch WebAssembly over to DISABLE_COMPONENTS (eventpipe and hot-relo…
773315f 
…ad).
@lateralusX
Add component link support in Android/iOS AppBuilder
95e5a36
@lateralusX
Add ability to disable link of static components into shared runtime …
f79ae26 
…lib.
@lateralusX
Enable diagnostics server TCP PAL for iOS and Android.
45c96d5
@lateralusX
Remove ep->ds dependecy using callback.
1891d94
@lateralusX
Bundle DiagnosticsServer/EventPipe in diagnostics_tracing component.
6b88bfa
@lateralusX
Fix warning.
3213dec
@lateralusX
Fix linking of none stub components on Android.
0c83477
@lateralusX
Remove changes done to components.md.
65cdb35
@lateralusX
Review feedback.
f15dc9b
@lateralusX
Fix none Windows build error.
28606d8
@lateralusX
Only include lib once in runtime artifacts when not building shared l…
58a349c 
…ibrary
@lateralusX
Only install static libraries on platforms currently shipping them.
277159c
@lateralusX lateralusX force-pushed the lateralusX/eventpipe-as-component branch from 42f99dd to 277159c Compare April 19, 2021 11:27
@lateralusX
Copy link
Member Author

Rebased on main to resolve build/test error in CoreClr on Linux.

@runfoapp runfoapp bot mentioned this pull request Apr 19, 2021
Closed
@lateralusX lateralusX merged commit 58b25df into dotnet:main Apr 20, 2021
Infrastructure Backlog automation moved this from In Progress to Done Apr 20, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@thaystg thaystg thaystg approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@CoffeeFlux CoffeeFlux Awaiting requested review from CoffeeFlux

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@vargaz vargaz Awaiting requested review from vargaz

Assignees
No one assigned
Labels
area-Build-mono area-Infrastructure-mono
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lateralusX @lambdageek @akoeplinger @thaystg @karelz