Mark PNSE-throwing methods in System.Net.NetworkInformation.IPGlobalProperties as unsupported on Android #50855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximLipnin
requested review from
marek-safar,
directhex,
steveisok,
akoeplinger and
mdh1418
|
Tagging subscribers to this area: @dotnet/ncl |
marek-safar
reviewed
Apr 7, 2021
src/libraries/System.Net.NetworkInformation/Directory.Build.props
Outdated
Show resolved
Hide resolved
This was referenced Apr 7, 2021
MaximLipnin
force-pushed
the
annotate_apis_throwing_pnse_on_android
branch
from
3f11c30
to
0bd467c
Compare
stephentoub
reviewed
Apr 8, 2021
...s/System.Net.NetworkInformation/src/System/Net/NetworkInformation/LinuxIPGlobalProperties.cs
Outdated
Show resolved
Hide resolved
akoeplinger
reviewed
Apr 13, 2021
src/libraries/System.Net.NetworkInformation/ref/System.Net.NetworkInformation.cs
Show resolved
Hide resolved
MaximLipnin
force-pushed
the
annotate_apis_throwing_pnse_on_android
branch
from
9f229bd
to
9fd99cd
Compare
marek-safar
approved these changes
Apr 15, 2021
MaximLipnin
changed the title
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #47911.
This is to annotate the following methods in
System.Net.NetworkInformation.IPGlobalPropertiesas unsupported on Android since they throw PNSE: