Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Task-based DisconnectAsync and refactor APM methods on top of it #51213

Merged
merged 3 commits into from
Apr 18, 2021

Conversation

geoffkizer
Copy link
Contributor

Add Task-based DisconnectAsync and refactor old APM Begin/EndDisconnect methods on top of it.

Also, generalize and improve disconnect tests.

Note that cancellation is not currently wired up for DisconnectAsync, even though it takes a CancellationToken. I'll file a separate issue for this.

Fixes #1608
Contributes to #43845

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Apr 14, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Add Task-based DisconnectAsync and refactor old APM Begin/EndDisconnect methods on top of it.

Also, generalize and improve disconnect tests.

Note that cancellation is not currently wired up for DisconnectAsync, even though it takes a CancellationToken. I'll file a separate issue for this.

Fixes #1608
Contributes to #43845

Author: geoffkizer
Assignees: -
Labels:

area-System.Net.Sockets, new-api-needs-documentation

Milestone: -

@geoffkizer
Copy link
Contributor Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@geoffkizer
Copy link
Contributor Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@geoffkizer
Copy link
Contributor Author

@antonfirsov -- I added a new helper TaskToApmBeginWithSyncExceptions that we should be able to use to address #47905 in general (but I've only implemented it for BeginDisconnect for now).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DisconnectAsync method in SocketTaskExtensions
4 participants