[release/6.0-preview4] Use same TimeZoneInfo implementation on iOS/tvOS as on browser #51497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…b.Shared.projitems Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
akoeplinger
added
area-CoreLib-mono
Servicing-consider
|
@marek-safar please approve |
marek-safar
approved these changes
Apr 19, 2021
|
@akoeplinger Can you take a look at these failures? |
|
@mmitche they're unrelated to this change since this PR only applies to iOS/tvOS. |
|
Looks like the failures are #51502 |
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #51457 to release/6.0-preview4
/cc @akoeplinger @filipnavara
Customer Impact
There is a bug in ICU that leads to deadlock when the time zone data are stripped. Since dotnet/icu uses the same stripping of data on all the platforms the time zone data are also not present on iOS/tvOS or any platform that consumes it.
We can workaround this ICU bug by using the stripped down version of TimeZoneInfo on iOS/tvOS.
See:
Testing
Manual testing.
Risk
Low, this aligns iOS/tvOS with what we do for Browser today.