Socket: delete unix local endpoint filename on Close #52103

tmds · 2021-04-30T12:54:54Z

ghost · 2021-04-30T12:55:01Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Author:	tmds
Assignees:	-
Labels:	`area-System.Net.Sockets`
Milestone:	-

tmds · 2021-04-30T13:03:14Z

I just realized relative paths need specific handling. The working directory may change between the time of Bind and Dispose. I'll update the PR for this, no need to review it yet.

wfurt · 2021-04-30T16:11:04Z

should the file be deleted only if created by .NET ? ... or is it always the case e.g. the local endpoint is transient?

tmds · 2021-05-03T12:05:52Z

should the file be deleted only if created by .NET ? ... or is it always the case e.g. the local endpoint is transient?

The file is created when the socket is bound. If the file is already there, the socket will fail to bind.

tmds · 2021-05-03T15:06:04Z

src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs

+        // correct type (IPEndPoint, etc). The Bind operation sets _rightEndPoint. Other operations must only set
+        // it when the value is still null.
+        // This enables tracking the file created by UnixDomainSocketEndPoint when the Socket is bound,
+        // and to delete that file when the Socket gets disposed.


I avoided adding a field to Socket for the stake of tracking the file to be deleted. Instead this is tracked through _rightEndPoint UnixDomainSocketEndPoint.BoundFileName.
On Bind an instance is created that has this property set. And on dispose, the file then gets deleted.

I've wondered this for a while... what does the "right" part of the name mean?

Just guessing: right type. The name is not very clear. Maybe we should change it to _typedEndpoint or _endpointType?

I keep asking this question every time I see that variable.

I don't really know either. Would love to understand.

It might be "right" in the sense that it's the result after resolving wildcards like port=0. Does that seem right?

src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs

tmds · 2021-05-11T12:01:53Z

@antonfirsov @geoffkizer can you continue reviewing this?

antonfirsov · 2021-05-11T12:28:56Z

@tmds the UnixDomainSocketEndPoint changes look good to me. I'm only concerned about caching optimizations (discussion above).

karelz · 2021-05-18T19:18:14Z

Triage: @tmds can you please remove endpoint optimization from this change? We can make it separate PR and discuss there if and how we want it to behave.

tmds · 2021-05-18T19:59:14Z

I need to look at the CI failures, they seem related to the change.

Triage: @tmds can you please remove endpoint optimization from this change? We can make it separate PR and discuss there if and how we want it to behave.

The discussion is more about #39313 than it is about this PR. Can we remove the optimization if it is decided to revert that PR? It will then happen as part of removing the _localEndPoint field that was introduced in #39313. @antonfirsov wdyt?

antonfirsov · 2021-05-19T09:34:23Z

@tmds we are undecided yet re reverting _localEndpoint I plan to open a separate issue to continue discussions on that topic. The point is that in this PR it is better to push this concern out of scope and revert the changes dealing with _localEndpoint, so this question does not block us to go ahead and merge the UDS improvement.

I need to look at the CI failures, they seem related to the change.

I can't see the failures, I assume it was outerloop which disappeared from the log, will rerun those tests.

antonfirsov · 2021-05-19T09:34:42Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2021-05-19T09:34:56Z

Azure Pipelines successfully started running 1 pipeline(s).

tmds · 2021-05-19T09:44:13Z

The point is that in this PR it is better to push this concern out of scope and revert the changes dealing with _localEndpoint, so this question does not block us to go ahead and merge the UDS improvement.

The concern isn't about how this PR uses _localEndpoint but whether there should be a _localEndpoint. I don't see why I shouldn't use it while it is here, but I'll remove it based on your feedback.

src/libraries/System.Net.Sockets/src/System/Net/Sockets/UnixDomainSocketEndPoint.cs

src/libraries/System.Net.Sockets/tests/FunctionalTests/UnixDomainSocketTest.cs

…that fails on Windows

stephentoub · 2021-05-25T01:11:07Z

src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs

@@ -284,7 +287,7 @@ public int Available
                {
                    // Update the state if we've become connected after a non-blocking connect.
                    _isConnected = true;
-                    _rightEndPoint = _nonBlockingConnectRightEndPoint;
+                    _rightEndPoint ??= _nonBlockingConnectRightEndPoint;


In what situation will it be non-null? I'm wondering in what situation we previously would have overwritten it and now we won't...

I didn't think about this much. I replaced everything with a conditional assignment except for the one in Bind.

It can be non-null if for example you Bind first, and then do a Connect and then call LocalEndPoint and end up in this branch.
We don't want to overwrite it because that will lose the tracking (via _rightEndPoint) of the unix socket file we need to delete.

~~Maybe it would make sense to add a test for this case, so we don't break it in the future.~~ Scratch it would be too difficult because of timing.

…sUnixDomainSockets condition

antonfirsov

Looks good after fixing the test (https://github.com/dotnet/runtime/pull/52103/files#r638644278) ~~and answering https://github.com/dotnet/runtime/pull/52103/files#r638385763~~ (missed the answer).

antonfirsov · 2021-05-25T19:15:51Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2021-05-25T19:16:05Z

Azure Pipelines successfully started running 1 pipeline(s).

antonfirsov

LGTM. CI failures are unrelated build failures.

… ConditionalFact attributes.

…asm_debugger_and_use_debugger_agent * upstream/main: (597 commits) Fix42292 (dotnet#52463) [mono] Remove some obsolete emscripten flags. (dotnet#53486) Fixed path to projects (dotnet#53435) support ServerCertificateContext in quic (dotnet#53175) Socket: delete unix local endpoint filename on Close (dotnet#52103) [mono] Fix sgen_gc_info.memory_load_bytes (dotnet#53364) Refactor MsQuic's native IP address types. (dotnet#53461) Re-enabled optimizations for gtFoldExprConst (dotnet#53347) Add diagnostic support into sample app and AppBuilders on Mono. (dotnet#53361) Fix issues with virtuals and mdarrays (dotnet#53400) Split Variant marshalling tests (dotnet#53035) Update clrjit.natvis to cover GT_SIMD and GT_HWINTRINSIC (dotnet#53470) remove WSL checks in tests (dotnet#53475) Always spawn message loop thread for SystemEvents (dotnet#53467) add AcceptAsync cancellation overloads (dotnet#53340) Remove unnecessary reference to iOS workload pack in the Mono workload (dotnet#53425) Add CookieContainer.GetAllCookies (dotnet#53441) Remove DynamicallyAccessedMembers on JsonSerializer (dotnet#53235) [wasm] Re-enable Wasm.Build.Tests (dotnet#53433) [libraries] Move library tests Feature Switches defaults to Functional tests (dotnet#53253) ...

Socket: delete unix local endpoint filename on Close

f76b269

dotnet-issue-labeler bot added the area-System.Net.Sockets label Apr 30, 2021

Handle delete of relative UnixDomainSocketEndPoint path

befd2a9

This comment has been minimized.

Sign in to view

tmds added 2 commits May 3, 2021 14:51

Cleanup tests

8ba0849

Track unix socket file ownership through _rightEndPoint

b52142b

tmds commented May 3, 2021

View reviewed changes

src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs Outdated Show resolved Hide resolved

tmds commented May 3, 2021

View reviewed changes

src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs Show resolved Hide resolved

tmds added 2 commits May 4, 2021 09:06

Fix Socket_SendReceive_Clone_Success test

4aca3c6

Merge branch 'main' into unix_socket_delete_file

e5e8717

Merge branch 'main' into unix_socket_delete_file

5696edf

tmds added 3 commits May 19, 2021 11:52

Remove code using _localEndPoint

2dde20f

Fix bad merge with master

779f3f7

Fix Socket_SendReceive_Clone_Success

580e4d9

tmds commented May 20, 2021

View reviewed changes

src/libraries/System.Net.Sockets/src/System/Net/Sockets/UnixDomainSocketEndPoint.cs Show resolved Hide resolved

tmds commented May 20, 2021

View reviewed changes

src/libraries/System.Net.Sockets/tests/FunctionalTests/UnixDomainSocketTest.cs Outdated Show resolved Hide resolved

Socket_ConnectAsyncUnixDomainSocketEndPoint_NotServer: remove Assert …

1cba885

…that fails on Windows

runfoapp bot mentioned this pull request May 20, 2021

InvokeCodeThatShouldFirEvents_EnsureEventsFired fails on OSX #52710

Closed

stephentoub reviewed May 25, 2021

View reviewed changes

UnixDomainSocketEndPoint_RelativePathDeletesFile: add PlatformSupport…

ae2f735

…sUnixDomainSockets condition

antonfirsov reviewed May 25, 2021

View reviewed changes

antonfirsov approved these changes May 26, 2021

View reviewed changes

UnixDomainSocketEndPoint_RelativePathDeletesFile: fix, can't have two…

f52250e

… ConditionalFact attributes.

antonfirsov merged commit d3ed5a9 into dotnet:main May 31, 2021

tmds mentioned this pull request May 31, 2021

Unix socket not cleaned up on exit dotnet/aspnetcore#14134

Closed

ghost locked as resolved and limited conversation to collaborators Jun 30, 2021

karelz added this to the 6.0.0 milestone Jul 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Socket: delete unix local endpoint filename on Close #52103

Socket: delete unix local endpoint filename on Close #52103

tmds commented Apr 30, 2021

ghost commented Apr 30, 2021

tmds commented Apr 30, 2021

wfurt commented Apr 30, 2021

This comment has been minimized.

This comment has been minimized.

tmds commented May 3, 2021

tmds May 3, 2021

stephentoub May 25, 2021

tmds May 25, 2021

antonfirsov May 25, 2021

geoffkizer May 25, 2021

tmds commented May 11, 2021

antonfirsov commented May 11, 2021

karelz commented May 18, 2021

tmds commented May 18, 2021

antonfirsov commented May 19, 2021

antonfirsov commented May 19, 2021

azure-pipelines bot commented May 19, 2021

tmds commented May 19, 2021

stephentoub May 25, 2021

tmds May 25, 2021

antonfirsov May 25, 2021 •

edited

Loading

antonfirsov left a comment •

edited

Loading

antonfirsov commented May 25, 2021

azure-pipelines bot commented May 25, 2021

antonfirsov left a comment

Socket: delete unix local endpoint filename on Close #52103

Socket: delete unix local endpoint filename on Close #52103

Conversation

tmds commented Apr 30, 2021

ghost commented Apr 30, 2021

tmds commented Apr 30, 2021

wfurt commented Apr 30, 2021

This comment has been minimized.

This comment has been minimized.

tmds commented May 3, 2021

tmds May 3, 2021

Choose a reason for hiding this comment

stephentoub May 25, 2021

Choose a reason for hiding this comment

tmds May 25, 2021

Choose a reason for hiding this comment

antonfirsov May 25, 2021

Choose a reason for hiding this comment

geoffkizer May 25, 2021

Choose a reason for hiding this comment

tmds commented May 11, 2021

antonfirsov commented May 11, 2021

karelz commented May 18, 2021

tmds commented May 18, 2021

antonfirsov commented May 19, 2021

antonfirsov commented May 19, 2021

azure-pipelines bot commented May 19, 2021

tmds commented May 19, 2021

stephentoub May 25, 2021

Choose a reason for hiding this comment

tmds May 25, 2021

Choose a reason for hiding this comment

antonfirsov May 25, 2021 • edited Loading

Choose a reason for hiding this comment

antonfirsov left a comment • edited Loading

Choose a reason for hiding this comment

antonfirsov commented May 25, 2021

azure-pipelines bot commented May 25, 2021

antonfirsov left a comment

Choose a reason for hiding this comment

antonfirsov May 25, 2021 •

edited

Loading

antonfirsov left a comment •

edited

Loading