ProcessInfo2 Diagnostics IPC Command #52258
Conversation
|
Tagging subscribers to this area: @tommcdon Issue Detailscloses #51592 Adds the ProcessInfo2 command to the Diagnostics IPC Protocol. New ver of the command includes the entrypoint assembly path and product version string. I'm opening this in draft mode for some additional test coverage while I hunt down how to retrieve the entrypoint assembly path in Mono (@lateralusX any ideas?). CC @jander-msft
|
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* TODO: get Mono's entrypoint asm
* command includes everything the first one did + product ver and entrypoint asm path * Add a test too
* fetch mono info from main assembly * remove ref naming * remove lazy method
* need to test still
* simplify access patterns * change API to utf8 * updated test
josalem
requested review from
jander-msft
and removed request for
CoffeeFlux,
thaystg,
BrzVlad,
steveharter,
layomia,
Jozkee,
SamMonoRT,
imhameed and
sywhang
add missing break statement from merge conflict fix
|
I don't believe the failures are related to these changes. @lateralusX can you take a look at the Mono changes? |
|
@steveisok or @lambdageek can someone take a look at the Mono changes. I'm pretty confident that the wasm and android failures are unrelated to these changes, but not 100%. |
|
Hello @josalem! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
closes #51592
related dotnet/diagnostics#2198
Adds the ProcessInfo2 command to the Diagnostics IPC Protocol.
New ver of the command includes the entrypoint assembly path and product version string.
I'm opening this in draft mode for some additional test coverage while I hunt down how to retrieve the entrypoint assembly path in Mono (@lateralusX any ideas?).
CC @jander-msft