Improve DOT flow graph dumping #52329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Do not include EH and Loop regions in the graph for inlinees. The data required for them is not valid in the inlinee compiler. 2. Do not include Loop regions in phases starting with the rationalizer. The loop table is not maintained, and decays, but we don't ever mark it as invalid. This is an arbitrary point after which it seems to be unmaintained (and can lead to asserts when using it). 3. Add the text "(inlinee)" to the function name in inlinee graph output, to distinguish it. 4. Fix a bug where the block map was using incorrect block number count for inlinees. 5. Fix a region insert bug when inserting a parent region after a child region where they share the end block (but the parent start block is earlier than the child). This happens in some EH region tables. Added some comments about all the different forms of region that need to be handled. 6. Add a `Verify` function to validate the constructed region tree. 7. Stop adding removed loops to the output.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@AndyAyersMS @dotnet/jit-contrib PTAL |
AndyAyersMS
approved these changes
May 5, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data required for them is not valid in the inlinee compiler.
The loop table is not maintained, and decays, but we don't ever mark it
as invalid. This is an arbitrary point after which it seems to be
unmaintained (and can lead to asserts when using it).
to distinguish it.
for inlinees.
region where they share the end block (but the parent start block is earlier
than the child). This happens in some EH region tables. Added some comments
about all the different forms of region that need to be handled.
Verifyfunction to validate the constructed region tree.