Include register selection heuristics in "Allocating Registers" table #52513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@dotnet/jit-contrib |
kunalspathak
commented
May 9, 2021
| REG_SEL_DEF(FREE, 0x10000, "FREE ") // It is not currently assigned to an *active* interval | ||
|
|
||
| // These are the original criteria for comparing registers that are free. | ||
| REG_SEL_DEF(CONST_AVAILABLE, 0x08000, "CONST") // It is a constant value that is already in an acceptable register. |
There was a problem hiding this comment.
Suggestions welcome for better 5 letter abbreviation for the scores.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the "Allocating Registers" table that is printed in JitDump to also include which heuristics was used to select the register. It comes handy when trying to figure out why a particular register was selected.
Here is the diff of old vs. new table:
The "Final allocation" table is untouched because it doesn't have the register selection heuristics information.
As part of the change, I have introduced
lsra_score.h(suggestion for better name are welcome) that contains the score names and I use it to populateRegisterScoreenum. Also, I have renamedlsrastats.htolsra_stats.h(for consistent naming) and moved the score specific entries intolsra_score.h.LsraStatenum is populated fromlsra_score.has well aslsra_stats.h.Other changes include space adjustments to print the table systematically.