Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move s_defaultSerializerOptions to JsonHelpers. #52557

Merged
merged 1 commit into from
May 13, 2021

Conversation

eerhardt
Copy link
Member

This allows for JsonContent to be trimmed in a default Blazor WASM app.

It isn't a large savings - roughly 200 bytes .br compressed.

@ghost
Copy link

ghost commented May 10, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

This allows for JsonContent to be trimmed in a default Blazor WASM app.

It isn't a large savings - roughly 200 bytes .br compressed.

Author: eerhardt
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming linker warning fixed.

This allows for JsonContent to be trimmed in a default Blazor WASM app.
@eerhardt
Copy link
Member Author

Failures of the following form:

You cannot extract a file outside of the target path

are #52596

@eerhardt
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@eerhardt
Copy link
Member Author

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt
Copy link
Member Author

Test failure is #52710.

@eerhardt eerhardt merged commit 05a8c76 into dotnet:main May 13, 2021
@eerhardt eerhardt deleted the TrimJsonContent branch May 13, 2021 16:34
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants