Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable EventSource_EventsRaisedAsExpected #52563

Merged
merged 1 commit into from
May 11, 2021
Merged

Disable EventSource_EventsRaisedAsExpected #52563

merged 1 commit into from
May 11, 2021

Conversation

karelz
Copy link
Member

@karelz karelz commented May 10, 2021

Disable failing test System.Net.Sockets.Tests.LoggingTest.EventSource_EventsRaisedAsExpected

Tracked by #50639

@karelz karelz requested a review from MihaZupan May 10, 2021 20:20
@ghost
Copy link

ghost commented May 10, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Disable failing test System.Net.Sockets.Tests.LoggingTest.EventSource_EventsRaisedAsExpected

Tracked by #50639

Author: karelz
Assignees: -
Labels:

area-System.Net.Sockets
Milestone: -

@MihaZupan MihaZupan mentioned this pull request May 10, 2021
Closed
@karelz karelz requested a review from a team May 11, 2021 08:26
@antonfirsov antonfirsov mentioned this pull request May 11, 2021
Closed
antonfirsov
antonfirsov approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karelz karelz merged commit be3f820 into dotnet:main May 11, 2021
@karelz karelz mentioned this pull request May 11, 2021
Closed
@MihaZupan MihaZupan mentioned this pull request May 11, 2021
Merged
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonfirsov antonfirsov antonfirsov approved these changes

@MihaZupan MihaZupan Awaiting requested review from MihaZupan

Assignees
No one assigned
Labels
area-System.Net.Sockets
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karelz @antonfirsov