-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QUIC stream limits #52704
Merged
+611
−163
Merged
QUIC stream limits #52704
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9b107cd
Stream limits are ints since they cannot be greater than ushort.MaxVa…
ManickaP fae4adc
Stream opening APIs made async.
ManickaP f74915e
Proper implementation of OpenStreamAsync, waiting for the msquic event.
ManickaP 8e92adb
WaitForAvailable*StreamsAsync
ManickaP dbb626d
WaitForAvailable*StreamsAsync implementation
ManickaP 20a5eee
WaitForAvailable*StreamsAsync usage in H3
ManickaP fdc4575
WaitForAvailable*StreamsAsync usage in H3 - fixed existing tests
ManickaP d9c087d
Added and fixed H/3 test.
ManickaP 622aa8f
Merge branch 'main' into mapichov/32079_stream_limit
ManickaP 30efc26
Post merge code fix
ManickaP 47358ef
Added some more tests and fixed token source
ManickaP ea92437
Fixed mock implementation and fixed completion source in msquic one.
ManickaP 36567a0
Merge branch 'main' into mapichov/32079_stream_limit
ManickaP 04c559d
Fixed active stream counting in mock connection.
ManickaP 6bd9ea7
Refactored stream limit work in mocks.
ManickaP 78b526d
Addressed PR comments.
ManickaP 9e64240
Merge branch 'main' into mapichov/32079_stream_limit
ManickaP 754be6f
Addressed feedback about stream openning.
ManickaP c5bb854
Added quic tests for WaitForAvailableStreamAsync.
ManickaP 910ab9f
Merge branch 'main' into mapichov/32079_stream_limit
ManickaP 97c4e53
Fixed access to _connection only under lock.
ManickaP 97b3185
Merge branch 'main' into mapichov/32079_stream_limit
ManickaP cbdd1df
Disabled one misbehaving test.
ManickaP 7eb7fb1
Addressed feedback.
ManickaP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 new tests pass on their own but if run within the whole suite they cause the crash with stream being finalized after the connection. That should be fixed with #52800, I'll revisit it enabling them afterwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed offline that it is caused by not accepted stream getting stuck inside accept queue and not being disposed there. You can try accepting it (after all test checks if it's important for the test) and disposing manually, or you may wait for Tomas' fix, your choice.