Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FileStreamOptions overloads #52720

Merged
merged 12 commits into from
Jun 10, 2021
Merged

Add FileStreamOptions overloads #52720

merged 12 commits into from
Jun 10, 2021

Commits on May 28, 2021

  1. Add FileOptions overloads to StreamReader and StreamWriter constructors

    @manandre
    manandre committed May 28, 2021
    Configuration menu
    Copy the full SHA
    a91d814 View commit details
    Browse the repository at this point in the history

  2. Add FileOptions overloads to File and FileInfo

    @manandre
    manandre committed May 28, 2021
    Configuration menu
    Copy the full SHA
    f878f5a View commit details
    Browse the repository at this point in the history

  3. Fix missing namespace prefix in System.Runtime reference

    @manandre
    manandre committed May 28, 2021
    Configuration menu
    Copy the full SHA
    1c4e12e View commit details
    Browse the repository at this point in the history

  4. Fix net48 build

    @manandre
    manandre committed May 28, 2021
    Configuration menu
    Copy the full SHA
    12f3d66 View commit details
    Browse the repository at this point in the history

  5. Move to option bag overloads

    @manandre
    manandre committed May 28, 2021
    Configuration menu
    Copy the full SHA
    763bfc0 View commit details
    Browse the repository at this point in the history

  6. Fix net48 build again

    @manandre
    manandre committed May 28, 2021
    Configuration menu
    Copy the full SHA
    6d13d07 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
    @manandre @adamsitnik
    manandre and adamsitnik committed May 31, 2021
    Configuration menu
    Copy the full SHA
    7cd83e9 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review continued

    @manandre
    manandre committed May 31, 2021
    Configuration menu
    Copy the full SHA
    42bb7f6 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. reduce the number of new APIs, File.Open(FileStreamOptions) should be… 

    … enough
    @adamsitnik
    adamsitnik committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    8f617d9 View commit details
    Browse the repository at this point in the history

  2. add missing docs

    @adamsitnik
    adamsitnik committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    f8e0bcf View commit details
    Browse the repository at this point in the history

  3. Align on options-based FileStream tests

    @manandre
    manandre committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    0711789 View commit details
    Browse the repository at this point in the history

  4. Add a test about encoding

    @manandre
    manandre committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    ee37481 View commit details
    Browse the repository at this point in the history