[ios/tvos] ARM64 simulator JIT Hack and CMAKE_SYSTEM_VARIANT iOSSimulator #52764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
requested review from
CoffeeFlux,
marek-safar and
vargaz
as code owners
|
/cc @steveisok |
steveisok
approved these changes
May 14, 2021
CoffeeFlux
reviewed
May 14, 2021
On iossimulator-arm64 and tvossimulator-arm64, use the pthread_jit_write_protect_np function to toggle the W^X bit for the current thread. Unfortunately, the above function is marked as __API_UNAVAILABLE on ios, tvos, watchos in the apple headers. But in the simulator frameworks it is still present and usable. So we declare our own prototype of the function and avoid the clang error. --- This reverts commit 89a816f, but for IOS simulator, not for Catalyst. That commit in turn reverted a9f1207 (ie this current commit is the same as a9f1207 but for ios simulator instead of catalyst)
For Mono, set HOST_DARWIN_SIMULATOR in cmake and C
lambdageek
force-pushed
the
add-iossimulator-arm64-jit-hack
branch
from
53de876
to
b2153bf
Compare
Updated the commit message and the PR description. We're only enabling this for iossimulator-arm64 and tvossimulator-arm64. The reasoning being is that those are meant to run just on the local development machine, so there is no risk of running afoul of any App Store rules. |
imhameed
reviewed
May 14, 2021
akoeplinger
reviewed
May 17, 2021
imhameed
approved these changes
May 17, 2021
apparently it wants to see literally `if (__builtin_available(...))`
lambdageek
commented
May 18, 2021
|
We don't need this anymore. #53197 added a no-exec mode to the code manager so that cross-compilers don't need to use the pthread write_protect function. And #51536 will use the "JustInterp" ( |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iossimulator-arm64 and tvossimulator-arm64, use the
pthread_jit_write_protect_npfunction to toggle the W^X bit for the current thread.Unfortunately, the above function is marked as
__API_UNAVAILABLEon ios, tvos, watchos in the apple headers. But in the simulator frameworks it is still present and usable. So we declare our own prototype of the function and avoid the clang error.This reverts commit 89a816f, but for iOS and tvOS simulators, not for Catalyst.
That commit in turn reverted a9f1207
(ie this current commit is the same as a9f1207 but for ios simulator instead of catalyst)
Build system changes:
Set
CMAKE_SYSTEM_VARIANTto "iOSSimulator" or "tvOSSimulator".In Mono, set
CMAKE_DARWIN_SIMULATOR