Check that 'lvDoNotEnregister' is set as necessary. #52802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreenko
added
the
area-CodeGen-coreclr
sandreenko
force-pushed
the
GitHub_49780_prep
branch
3 times, most recently
from
378b981
to
1a62d7d
Compare
added 2 commits
May 26, 2021 20:46
Check that we don't have independently promoted LCL_VAR that are references after lowering. Check that all LclVars that have ADDR() on top of them are marked as doNotEnreg. In the past when we did not enregister structs we were allocating them on the stack even without doNotEnreg set.
sandreenko
force-pushed
the
GitHub_49780_prep
branch
from
1a62d7d
to
ca4fb4d
Compare
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sandreenko
changed the title
|
I think this is ready for review, PTAL @dotnet/jit-contrib |
|
You can ignore the pgo failures, sorry about that. |
AndyAyersMS
approved these changes
May 27, 2021
Sound valuable, will add in one of the next changes. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable #43867 by default we need to make sure that all structs that should be on the stack are marked as doNotEnreg. Currently, it is not very important because all structs are getting their 'doNotEnreg' just because they are structs.
This PR adds check that after lowering we have correct
lvDoNotEnregflag on variables that are accessed via their address or via non-promoted fields or with both promoted and non-promoted accesses.If you see more contracts related to doNotEnreg that can be added - please comment. There are also many unclear parts about multi-reg nodes that I am going to address soon.
No diffs (all available spmi collections) as expected.
Fixes #49780 (change in rationalize RewriteSIMDIndir).
Contributes to #43867, needed #53269 (phi store of long vars were not decomposed so the contract for them did not hold), #53067, #52803.