[mono][wasm] Avoid AOTing methods with clauses, use the interpreter instead. #52883

vargaz · 2021-05-18T02:47:59Z

No description provided.

ghost · 2021-05-18T02:48:07Z

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

Issue Details

Author:	vargaz
Assignees:	-
Labels:	`area-Codegen-Interpreter-mono`
Milestone:	-

radekdoulik · 2021-05-18T14:52:01Z

Tried to run the browser-bench sample on chrome/amd64 to compare it to #52846. It crashes in the TryCatchThrow without any information in the console.

So I used firefox instead and remeasured the #52846 and this PR.

firefox/amd64/AOT:

measurement	before	after
Exceptions, NoExceptionHandling	0.0148us	0.0151us
Exceptions, TryCatch	0.1541us	0.3796us
Exceptions, TryCatchThrow	0.0134ms	0.0232ms
Exceptions, TryCatchFilter	0.3844us	0.4336us
Exceptions, TryCatchFilterInline	0.1423us	0.1422us
Json, non-ASCII text serialize	1.1937ms	1.4946ms
Json, non-ASCII text deserialize	5.3005ms	5.4476ms
Json, small serialize	0.1945ms	0.2138ms
Json, small deserialize	0.2243ms	0.2996ms
Json, large serialize	51.7475ms	56.7634ms
Json, large deserialize	59.5862ms	79.8235ms

It also looks like the JS rountrip overhead is lower on firefox compared to chrome.

radekdoulik · 2021-05-18T14:59:40Z

I will also try to use it with the test case from #52394

akoeplinger · 2021-05-19T14:18:21Z

Could we emit a log message in the AOT compiler when we hit such methods to make it easier to extract them?

radekdoulik · 2021-05-19T17:16:41Z

Nice, the recent changes fix the crashes in chrome and also in the disabled measurements.

The times look like this now:

measurement	before	after
Exceptions, NoExceptionHandling	0.0166us	0.0165us
Exceptions, TryCatch	0.1413us	0.4183us
Exceptions, TryCatchThrow	0.0065ms	0.0126ms
Exceptions, TryCatchFilter	0.4460us	0.4263us
Exceptions, TryCatchFilterThrow		0.0138ms
Exceptions, TryCatchFilterThrowApplies		0.0127ms
Exceptions, TryCatchFilterInline	0.1287us	0.1244us
Json, non-ASCII text serialize	1.4873ms	1.4281ms
Json, non-ASCII text deserialize	6.7141ms	6.5593ms
Json, small serialize	0.2106ms	0.2017ms
Json, small deserialize	0.2376ms	0.2790ms
Json, large serialize	55.5699ms	52.8144ms
Json, large deserialize	64.3457ms	75.0725ms

lewing · 2021-05-19T22:15:29Z

If looks like maybe the ascii json deserialize path does a lot of work in a method with a clause?

lewing · 2021-05-19T22:20:55Z

@vargaz is the gc fix more general than this pr?

vargaz · 2021-05-19T22:25:09Z

Yes.

lewing · 2021-05-20T19:30:29Z

Most of the failures are resolved but there are still a few kinds

[00:42:33] info: console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
[00:42:33] info: console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
[00:42:33] info: console.info: Initializing.....
[00:42:33] info: Discovering: System.Net.Http.Unit.Tests.dll (method display = ClassAndMethod, method display options = None)
[00:42:33] info: Discovered:  System.Net.Http.Unit.Tests.dll (found 902 of 906 test cases)
[00:42:33] info: Starting:    System.Net.Http.Unit.Tests.dll
[00:42:34] fail: [FAIL] System.Net.Http.Tests.HttpHeadersTest.GetEnumerator_UseExplicitInterfaceImplementation_EnumeratorReturnsNoOfHeaders
[00:42:34] info: Assert.True() Failure
[00:42:34] info: Expected: True
[00:42:34] info: Actual:   False
[00:42:34] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[00:42:34] fail: [FAIL] System.Net.Http.Tests.HttpHeadersTest.GetEnumerator_FirstHeaderWithOneValueSecondHeaderWithTwoValues_EnumeratorReturnsTwoHeaders
[00:42:34] info: Assert.True() Failure
[00:42:34] info: Expected: True
[00:42:34] info: Actual:   False
[00:42:34] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[00:42:34] fail: [FAIL] System.Net.Http.Tests.HttpHeadersTest.GetEnumerator_FirstCustomHeaderWithEmptyValueSecondKnownHeaderWithEmptyValue_EnumeratorReturnsOneHeader
[00:42:34] info: Assert.True() Failure
[00:42:34] info: Expected: True
[00:42:34] info: Actual:   False
[00:42:34] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[00:42:48] info: Finished:    System.Net.Http.Unit.Tests.dll
[00:42:48] info: 
[00:42:48] info: === TEST EXECUTION SUMMARY ===
[00:42:48] info: Total: 2021, Errors: 0, Failed: 3, Skipped: 17, Time: 14.933803s
[00:42:48] info: 
[00:42:48] info: Process v8 exited with 1


[00:50:23] info: Discovering: Microsoft.VisualBasic.Core.Tests.dll (method display = ClassAndMethod, method display options = None)
[00:50:23] info: Discovered:  Microsoft.VisualBasic.Core.Tests.dll (found 704 of 719 test cases)
[00:50:23] info: Starting:    Microsoft.VisualBasic.Core.Tests.dll
[00:50:27] fail: [FAIL] Microsoft.VisualBasic.Tests.FileSystemTests.Write_ArgumentException
[00:50:27] info: System.IO.IOException : Bad file name or number.
[00:50:27] info:    at Microsoft.VisualBasic.FileSystem.Write(Int32 , Object[] )
[00:50:27] info:    at Microsoft.VisualBasic.Tests.FileSystemTests.<>c__DisplayClass21_0.<Write_ArgumentException>b__0()
[00:50:27] info:    at Microsoft.VisualBasic.Tests.FileSystemTests.AssertThrows[ArgumentException](Action action)
[00:50:27] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[00:50:27] fail: [FAIL] Microsoft.VisualBasic.Tests.FileSystemTests.FileClose
[00:50:27] info: Assert.Equal() Failure
[00:50:27] info: Expected: 2
[00:50:27] info: Actual:   1
[00:50:27] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[00:50:27] fail: [FAIL] Microsoft.VisualBasic.Tests.FileSystemTests.FileOpen
[00:50:27] info: Assert.Throws() Failure
[00:50:27] info: Expected: typeof(System.IO.IOException)
[00:50:27] info: Actual:   (No exception was thrown)
[00:50:27] info:    at Microsoft.VisualBasic.Tests.FileSystemTests.AssertThrows[IOException](Action action)
[00:50:27] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[00:50:45] info: Finished:    Microsoft.VisualBasic.Core.Tests.dll
[00:50:45] info: 


                 
                 
[00:51:17] info: console.info: Arguments: --run,WasmTestRunner.dll,System.Text.RegularExpressions.Tests.dll,-notrait,category=IgnoreForCI,-notrait,category=OuterLoop,-notrait,category=failing
[00:51:17] info: console.debug: MONO_WASM: Initializing mono runtime
[00:51:17] info: console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
[00:51:17] info: console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
[00:51:17] info: console.info: Initializing.....
[00:51:17] info: Discovering: System.Text.RegularExpressions.Tests.dll (method display = ClassAndMethod, method display options = None)
[00:51:17] info: Discovered:  System.Text.RegularExpressions.Tests.dll (found 200 of 218 test cases)
[00:51:17] info: Starting:    System.Text.RegularExpressions.Tests.dll
[00:51:17] fail: [FAIL] System.Text.RegularExpressions.Tests.RegexSplitTests.Split
[00:51:17] info: System.Exception : Test method 'Split_TestData' not found
[00:51:17] info:    at System.Text.RegularExpressions.Tests.RegexCompilationHelper.TransformRegexOptions(String testDataMethodName, Int32 regexOptionsArrayIndex)
[00:51:17] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[00:51:23] fail: [FAIL] System.Text.RegularExpressions.Tests.RegexMultipleMatchTests.Matches
[00:51:23] info: System.Exception : Test method 'Matches_TestData' not found
[00:51:23] info:    at System.Text.RegularExpressions.Tests.RegexCompilationHelper.TransformRegexOptions(String testDataMethodName, Int32 regexOptionsArrayIndex)
[00:51:23] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[00:51:35] fail: [FAIL] System.Text.RegularExpressions.Tests.RegexMatchTests.Match_Advanced
[00:51:35] info: System.Exception : Test method 'Match_Advanced_TestData' not found
[00:51:35] info:    at System.Text.RegularExpressions.Tests.RegexCompilationHelper.TransformRegexOptions(String testDataMethodName, Int32 regexOptionsArrayIndex)
[00:51:35] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[00:51:35] fail: [FAIL] System.Text.RegularExpressions.Tests.RegexMatchTests.Match
[00:51:35] info: System.Exception : Test method 'Match_Basic_TestData' not found
[00:51:35] info:    at System.Text.RegularExpressions.Tests.RegexCompilationHelper.TransformRegexOptions(String testDataMethodName, Int32 regexOptionsArrayIndex)
[00:51:35] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[00:51:35] fail: [FAIL] System.Text.RegularExpressions.Tests.RegexMatchTests.Match_StartatDiffersFromBeginning
[00:51:35] info: System.Exception : Test method 'Match_StartatDiffersFromBeginning_MemberData' not found
[00:51:35] info:    at System.Text.RegularExpressions.Tests.RegexCompilationHelper.TransformRegexOptions(String testDataMethodName, Int32 regexOptionsArrayIndex)
[00:51:35] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[00:51:38] fail: [FAIL] System.Text.RegularExpressions.Tests.RegexReplaceTests.Replace
[00:51:38] info: System.Exception : Test method 'Replace_String_TestData' not found
[00:51:38] info:    at System.Text.RegularExpressions.Tests.RegexCompilationHelper.TransformRegexOptions(String testDataMethodName, Int32 regexOptionsArrayIndex)
[00:51:38] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[00:51:38] fail: [FAIL] System.Text.RegularExpressions.Tests.RegexReplaceTests.Replace_MatchEvaluator_Test
[00:51:38] info: System.Exception : Test method 'Replace_MatchEvaluator_TestData' not found
[00:51:38] info:    at System.Text.RegularExpressions.Tests.RegexCompilationHelper.TransformRegexOptions(String testDataMethodName, Int32 regexOptionsArrayIndex)
[00:51:38] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[00:51:38] info: Finished:    System.Text.RegularExpressions.Tests.dll
[00:51:38] info: 
[00:51:38] info: === TEST EXECUTION SUMMARY ===
[00:51:38] info: Total: 6541, Errors: 0, Failed: 7, Skipped: 12, Time: 21.1881339s
[00:51:38] info: 
[00:51:39] info: Process v8 exited with 1

lewing · 2021-05-25T22:40:46Z

@vargaz any idea what is going on with the remaining failures?

vargaz · 2021-05-26T01:18:10Z

The Microsoft.VisualBasic failures seem to be related to calls made to Assembly.GetCallingAssembly () which is not supported in wasm+aot, not sure why this worked previously.

vargaz · 2021-05-26T02:44:25Z

Testcase for the System.Net.Http failures:

public class Test : IEnumerable<string>
{
        public IEnumerator<string> GetEnumerator()
        {
            var l = new List<string> ();
            l.Add ("A");
            foreach (var v in l)
                yield return "FOO";
        }

        IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();

    public static void Main () {
        var t = new Test ();
        var en = t.GetEnumerator ();
        Console.WriteLine ("V: " + en.MoveNext ());
    }
}

radical · 2021-05-26T16:19:21Z

@vargaz is the gc fix more general than this pr?

Is that just this commit - ba54702 ? Should I expect it to work, if cherry-picked to the AOT test PR?

vargaz · 2021-05-26T16:41:48Z

@vargaz is the gc fix more general than this pr?

Is that just this commit - ba54702 ? Should I expect it to work, if cherry-picked to the AOT test PR?

Yes

vargaz · 2021-05-27T13:28:21Z

The only failures left are the ones in Microsoft.VisualBasic.Core.Tests. I think those tests should be disabled because of their usage of Assembly.GetCallingAssembly ().

lewing · 2021-05-27T18:25:16Z

@radekdoulik can we get updated timings now?

lewing · 2021-05-27T18:26:13Z

@vargaz are you in favor of taking the change?

src/mono/mono/mini/mini-exceptions.c

ghost · 2021-06-03T19:02:42Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Author:	vargaz
Assignees:	-
Labels:	`arch-wasm`, `area-Codegen-Interpreter-mono`
Milestone:	-

vargaz · 2021-06-03T19:11:10Z

Still some relevant failures.

…nstead. This will hopefully fix semantical problems with filter clauses.

… entries.

… cannot be handled in the frames below the interp_entry () call.

Stack walks are not supported on wasm, and the workarounds depend on inserting code into the caller, i.e. callers of GetExecutingAssembly (), so if the caller is interpreted, the workaround is not generated.

radekdoulik · 2021-06-07T14:46:42Z

Nice to see it in green, great work @vargaz.

Fresh measurements on Chrome/AOT against main with the same hash this was rebased at:

measurement	main	PR
Exceptions, NoExceptionHandling	0.0163us	0.0164us
Exceptions, TryCatch	0.0943us	0.2914us
Exceptions, TryCatchThrow	0.0047ms	0.0091ms
Exceptions, TryCatchFilter	0.3429us	0.3074us
Exceptions, TryCatchFilterInline	0.1095us	0.1099us
Json, non-ASCII text serialize	1.3103ms	1.3386ms
Json, non-ASCII text deserialize	5.4513ms	5.3631ms
Json, small serialize	0.1657ms	0.1649ms
Json, small deserialize	0.1911ms	0.2291ms
Json, large serialize	44.8772ms	44.7281ms
Json, large deserialize	51.5842ms	61.5765ms

radical · 2021-06-07T15:11:22Z

AOT runtime-staging failures:

System.Runtime.Serialization.Xml.ReflectionOnly.Tests - timing out, same as main, likely caused by the 2.0.21 Emscripten bump
System.Runtime.Serialization.Xml.Tests - same as above
Microsoft.VisualBasic.Core.Tests(log) - this is not failing on main:

[18:33:08] fail: [FAIL] Microsoft.VisualBasic.Tests.FileSystemTests.Write_ArgumentException
[18:33:08] info: System.IO.IOException : Bad file name or number.
[18:33:08] info:    at Microsoft.VisualBasic.FileSystem.Write(Int32 , Object[] )
[18:33:08] info:    at Microsoft.VisualBasic.Tests.FileSystemTests.<>c__DisplayClass21_0.<Write_ArgumentException>b__0()
[18:33:08] info:    at Microsoft.VisualBasic.Tests.FileSystemTests.AssertThrows[ArgumentException](Action action)
[18:33:08] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[18:33:08] fail: [FAIL] Microsoft.VisualBasic.Tests.FileSystemTests.FileClose
[18:33:08] info: Assert.Equal() Failure
[18:33:08] info: Expected: 2
[18:33:08] info: Actual:   1
[18:33:08] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[18:33:08] fail: [FAIL] Microsoft.VisualBasic.Tests.FileSystemTests.FileOpen
[18:33:08] info: Assert.Throws() Failure
[18:33:08] info: Expected: typeof(System.IO.IOException)
[18:33:08] info: Actual:   (No exception was thrown)
[18:33:08] info:    at Microsoft.VisualBasic.Tests.FileSystemTests.AssertThrows[IOException](Action action)
[18:33:08] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
[18:33:27] info: Finished:    Microsoft.VisualBasic.Core.Tests.dll
[18:33:27] info: 
[18:33:27] info: === TEST EXECUTION SUMMARY ===
[18:33:27] info: Total: 22222, Errors: 0, Failed: 3, Skipped: 3, Time: 25.016673s

vargaz · 2021-06-07T15:21:11Z

for the visualbasic failure, see:
#52883 (comment)

vargaz requested review from BrzVlad, CoffeeFlux, EgorBo, imhameed, lambdageek and SamMonoRT as code owners May 18, 2021 02:47

dotnet-issue-labeler bot added the area-Codegen-Interpreter-mono label May 18, 2021

vargaz added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 18, 2021

vargaz marked this pull request as draft May 18, 2021 02:48

vargaz force-pushed the wasm-no-eh branch 2 times, most recently from ad8b3cb to fd9cd71 Compare May 18, 2021 23:28

vargaz force-pushed the wasm-no-eh branch from 1d7da50 to 6920182 Compare May 26, 2021 21:50

vargaz reopened this Jun 2, 2021

vargaz marked this pull request as ready for review June 2, 2021 13:41

lewing reviewed Jun 2, 2021

View reviewed changes

src/mono/mono/mini/mini-exceptions.c Outdated Show resolved Hide resolved

vargaz force-pushed the wasm-no-eh branch from 0326248 to cb8fcc5 Compare June 2, 2021 18:03

vargaz added arch-wasm WebAssembly architecture and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Jun 3, 2021

radical mentioned this pull request Jun 3, 2021

[wasm][aot] Regression: lots of AOT tests failing on main #53697

Closed

vargaz force-pushed the wasm-no-eh branch 3 times, most recently from d9ad62b to db1eb89 Compare June 5, 2021 04:52

vargaz added 5 commits June 5, 2021 13:11

[mono][wasm] Avoid AOTing methods with clauses, use the interpreter i…

5292126

…nstead. This will hopefully fix semantical problems with filter clauses.

[mono] Avoid interp->llvm calls to llvm methods which are just interp…

d50a827

… entries.

Clear llvm exceptions in the interp code after loading them.

e51f7ff

Handle the case when interp_entry () rethrows an exception becuase it…

c26a8e8

… cannot be handled in the frames below the interp_entry () call.

Avoid interp->jit calls to methods doing stack walks.

789a4cb

Stack walks are not supported on wasm, and the workarounds depend on inserting code into the caller, i.e. callers of GetExecutingAssembly (), so if the caller is interpreted, the workaround is not generated.

vargaz force-pushed the wasm-no-eh branch from db1eb89 to 789a4cb Compare June 5, 2021 17:11

marek-safar requested a review from lewing June 7, 2021 06:32

BrzVlad approved these changes Jun 7, 2021

View reviewed changes

radical mentioned this pull request Jun 7, 2021

[wasm][aot] Microsoft.VisualBasic.Tests.FileSystemTests failing due to use of Assembly.GetCallingAssembly #53815

Open

Disable some failing tests.

ee04ea4

radical merged commit d173cca into dotnet:main Jun 7, 2021

vargaz deleted the wasm-no-eh branch June 8, 2021 00:07

BrzVlad mentioned this pull request Jun 14, 2021

[wasm] Exception filter clause evaluated at wrong time #52394

Closed

lewing mentioned this pull request Jun 17, 2021

Exception filters handling in WebAssembly AOT #46927

Closed

ghost locked as resolved and limited conversation to collaborators Jul 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[mono][wasm] Avoid AOTing methods with clauses, use the interpreter instead. #52883

[mono][wasm] Avoid AOTing methods with clauses, use the interpreter instead. #52883

vargaz commented May 18, 2021

ghost commented May 18, 2021

radekdoulik commented May 18, 2021

radekdoulik commented May 18, 2021

akoeplinger commented May 19, 2021

radekdoulik commented May 19, 2021

lewing commented May 19, 2021 •

edited

Loading

lewing commented May 19, 2021

vargaz commented May 19, 2021

lewing commented May 20, 2021

lewing commented May 25, 2021

vargaz commented May 26, 2021

vargaz commented May 26, 2021

radical commented May 26, 2021

vargaz commented May 26, 2021

vargaz commented May 27, 2021

lewing commented May 27, 2021

lewing commented May 27, 2021

ghost commented Jun 3, 2021

vargaz commented Jun 3, 2021

radekdoulik commented Jun 7, 2021

radical commented Jun 7, 2021

vargaz commented Jun 7, 2021

[mono][wasm] Avoid AOTing methods with clauses, use the interpreter instead. #52883

[mono][wasm] Avoid AOTing methods with clauses, use the interpreter instead. #52883

Conversation

vargaz commented May 18, 2021

ghost commented May 18, 2021

radekdoulik commented May 18, 2021

radekdoulik commented May 18, 2021

akoeplinger commented May 19, 2021

radekdoulik commented May 19, 2021

lewing commented May 19, 2021 • edited Loading

lewing commented May 19, 2021

vargaz commented May 19, 2021

lewing commented May 20, 2021

lewing commented May 25, 2021

vargaz commented May 26, 2021

vargaz commented May 26, 2021

radical commented May 26, 2021

vargaz commented May 26, 2021

vargaz commented May 27, 2021

lewing commented May 27, 2021

lewing commented May 27, 2021

ghost commented Jun 3, 2021

vargaz commented Jun 3, 2021

radekdoulik commented Jun 7, 2021

radical commented Jun 7, 2021

vargaz commented Jun 7, 2021

lewing commented May 19, 2021 •

edited

Loading