Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DSA.Create, AesCcm, AesGcm, ChaCha20Poly1305 throw PNSE on iOS #52978

Merged
merged 16 commits into from May 21, 2021
Merged

Make DSA.Create, AesCcm, AesGcm, ChaCha20Poly1305 throw PNSE on iOS #52978

merged 16 commits into from May 21, 2021

Conversation

filipnavara
Copy link
Member

@filipnavara filipnavara commented May 19, 2021 •
edited

Fixes #52758
Fixes #51332
Fixes #51331
Fixes #51330
Fixes #51370

This PR re-enables all System.Security.Cryptography.* tests to ensure sufficient coverage of the change.

@ghost
Copy link

ghost commented May 19, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: filipnavara
Assignees: -
Labels:

area-System.Security
Milestone: -

@filipnavara filipnavara marked this pull request as ready for review May 20, 2021 06:13
@filipnavara filipnavara mentioned this pull request May 20, 2021
Closed
filipnavara
filipnavara commented May 20, 2021
View reviewed changes
src/libraries/System.Security.Cryptography.Algorithms/src/System/Security/Cryptography/DSA.cs
public static new DSA Create()
{
return CreateCore();
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indirection is necessary because of the UnsupportedOSPlatform attributes which would otherwise have to be in 5 different places.

@marek-safar marek-safar added the os-ios Apple iOS label May 20, 2021
@filipnavara filipnavara mentioned this pull request May 20, 2021
Closed
@filipnavara
Copy link
Member Author

Commit fdc95f2 passed all the relevant tests on iOS and tvOS Simulators in runtime-staging. There were few test exclusions that had to be updated for Mac Catalyst which should pass with c663d2a.

@steveisok steveisok requested a review from bartonjs May 20, 2021 17:43
@runfoapp runfoapp bot mentioned this pull request May 20, 2021
Closed
@marek-safar marek-safar merged commit 5c80887 into dotnet:main May 21, 2021
@MaximLipnin MaximLipnin mentioned this pull request May 24, 2021
Closed
27 tasks
@dotnet dotnet locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marek-safar marek-safar marek-safar left review comments

@MaximLipnin MaximLipnin MaximLipnin left review comments

@steveisok steveisok steveisok approved these changes

@bartonjs bartonjs Awaiting requested review from bartonjs

Assignees
No one assigned
Labels
area-System.Security os-ios Apple iOS
Projects
None yet
Milestone
No milestone
4 participants
@filipnavara @marek-safar @steveisok @MaximLipnin