Rename superpmi tests collection names #53108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename tests.pmi to coreclr_tests.pmi - Rename tests_libraries.pmi to libraries_tests.pmi
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@dotnet/jit-contrib |
BruceForstall
approved these changes
May 26, 2021
|
@kunalspathak Are you going to kick off the collection pipeline with these new names? (the last run had a couple apparently infra failures that are worth re-trying anyway) |
|
Could you do it @BruceForstall ? I am outside and don't have access to the pipeline. |
|
Done. Fyi, #51998 will soon change the GUID again. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After introducing libraries tests collection, whenever I filter the collection to
-f libraries.pmi, thetests_libraries.pmialso gets picked up, downloaded and ran. To differentiate, I have renamed the libraries tests collection tolibraries_tests.pmiand for consistency, thetests.pmitocoreclr_tests.pmi. That way, if someone specified-f tests.pmi, both libraries and coreclr collection can be downloaded and run.tests.pmitocoreclr_tests.pmitests_libraries.pmitolibraries_tests.pmi