Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from mono/linker #53144

Merged
merged 5 commits into from
May 28, 2021
Merged

[main] Update dependencies from mono/linker #53144

merged 5 commits into from
May 28, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 23, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/mono/linker

  • Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
  • Build: 20210527.2
  • Date Produced: 5/27/2021 6:25 PM
  • Commit: 50901f9ba5c8672c2758577a61f45fea3cc6cd76
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210521.1
0df45cd 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.5.21267.3 -> To Version 6.0.100-preview.5.21271.1
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@marek-safar
Copy link
Contributor

@vitek-karas could you have a look if the warnings are correct and need more annotations on the libraries side?

@vitek-karas
Copy link
Member

I'm investigating. There's something weird going on. It only fails on non-Windows.

@vitek-karas vitek-karas mentioned this pull request May 24, 2021
Merged
@vitek-karas
Copy link
Member

The failures is caused by linker warnings coming from EventSourceActivity, which is a class which is normally trimmed away. I filed #53177 to track the fact that the class doesn't seem to be used by anything.

The reason for the failure is the recent change in linker which introduced support for feature switches in generated descriptor for CoreLib. The change has a bug which will add <assembly name="System.Private.CoreLib"/> element into the descriptor effectively rooting the entire assembly. This leads into including the EventSourceActivity in the output, and thus generating warnings for it. Fix for this is available in dotnet/linker#2051.

vitek-karas added a commit to dotnet/linker that referenced this pull request May 24, 2021
@vitek-karas
Fix a problem where generating an empty FS assembly element roots the…
4d42726 
… whole assembly (#2051)

Descriptors have the behavior that specifying just the assembly element without any children will root the entire assembly (and everything in it). The same applies to types (specifying just the type element will mark the entire type).
With the new feature switches, we have to be careful to not generate an empty assembly element, otherwise we will accidentally root the entire corelib.

Fixes the problem seen in dotnet/runtime#53144.
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210524.3
e4e44b3 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.5.21267.3 -> To Version 6.0.100-preview.5.21274.3
@vitek-karas
Copy link
Member

@LakshanF can you please take a look at the test failures here?
It seems the linker update broke event source - tests which rely on listening in-proc don't work (or at least some of them don't). This could be related to dotnet/linker@2cf3082 as well though.

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210525.1
c92d42b 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.5.21267.3 -> To Version 6.0.100-preview.6.21275.1
@LakshanF
Copy link
Member

Will check, I wanted to revisit the eventsource change you mention, dotnet/linker@2cf3082, since I had concerns around how nested types will be managed in EventSource since that would not have been covered by the type hierarchy feature (which I believe caused this change)

/cc @marek-safar

@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210526.2
a95724f 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.5.21267.3 -> To Version 6.0.100-preview.6.21276.2
@runfoapp runfoapp bot mentioned this pull request May 27, 2021
Open
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210527.2
cf44db2 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.5.21267.3 -> To Version 6.0.100-preview.6.21277.2
@dotnet-maestro dotnet-maestro bot merged commit 33b0f24 into main May 28, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-85789cd4-147c-4b5d-b52c-0edbd879ae91 branch May 28, 2021 15:48
@runfoapp runfoapp bot mentioned this pull request May 28, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2021
@danmoseley danmoseley added the area-codeflow for labeling automated codeflow label Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitek-karas vitek-karas vitek-karas approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marek-safar @vitek-karas @LakshanF @danmoseley