Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pgo testing to outerloop #53301

Merged
merged 3 commits into from
May 27, 2021
Merged

Add pgo testing to outerloop #53301

merged 3 commits into from
May 27, 2021

Conversation

AndyAyersMS
Copy link
Member

Also update jit-experimental to no longer run PGO or EH WriteThru.

@AndyAyersMS
Add pgo testing to outerloop
04ed8f2 
Also update jit-experimental to no longer run PGO or EH WriteThru.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@AndyAyersMS
Copy link
Member Author

cc @dotnet/jit-contrib

@AndyAyersMS
Copy link
Member Author

Ignore dotnet.runtime (1) as I didnt get the name right initially.

BruceForstall
BruceForstall approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should rename the pipelines "runtime-coreclr pgo" and "runtime-coreclr libraries-pgo"

eng/pipelines/coreclr/libraries-pgo.yml Outdated

schedules:
- cron: "0 16 * * 0,6"
displayName: Sun at 8:00 AM (UTC-8:00)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: looks like the 'cron' is Sat and Sun

eng/pipelines/coreclr/pgo.yml

schedules:
- cron: "0 0 * * *"
displayName: Mon through Sun at 12:00 AM (UTC-8:00)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cron "0 0" is midnight UTC, so 4pm PDT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update these.

@AndyAyersMS
Copy link
Member Author

Libraries failures are unrelated.

Linux debug x64 libraries test failure is in post-test reporting.

Searching '/root/helix/work/workitem/uploads' for test results files
Fatal Python error: could not acquire lock for <_io.BufferedWriter name='<stdout>'> at interpreter shutdown, possibly due to daemon threads
Python runtime state: finalizing (tstate=0x55dc30e0ac00)

the other two legs fail this test (seems like a novel failure)

    System.IO.Tests.SymbolicLink_Changed_Tests.FileSystemWatcher_DirectorySymbolicLink_TargetsFile_Fails [FAIL]
      Assert.Throws() Failure
      Expected: typeof(System.IO.FileNotFoundException)
      Actual:   (No exception was thrown)

@AndyAyersMS
Copy link
Member Author

71 test failures in libraries tests, 10 in jit tests.

@AndyAyersMS
Copy link
Member Author

Scanned through the various failing tests and they're all getting the expected complus settings.

@AndyAyersMS AndyAyersMS added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 27, 2021
@AndyAyersMS AndyAyersMS added this to Needs Triage in .NET Core CodeGen via automation May 27, 2021
@AndyAyersMS AndyAyersMS removed this from Needs Triage in .NET Core CodeGen May 27, 2021
@AndyAyersMS AndyAyersMS added this to Needs Triage in .NET Core CodeGen via automation May 27, 2021
@AndyAyersMS AndyAyersMS moved this from Needs Triage to PGO in .NET Core CodeGen May 27, 2021
@AndyAyersMS AndyAyersMS self-assigned this May 27, 2021
@AndyAyersMS
Copy link
Member Author

Not entirely sure why the pgo jobs got retriggered on push .... anybody know?

@BruceForstall
Copy link
Member

Not entirely sure why the pgo jobs got retriggered on push .... anybody know?

Seems unexpected.

@AndyAyersMS
Copy link
Member Author

I guess what I'm wondering is if these new pipelines are somehow attached to PRs/Innerloop -- how can I check that?

@BruceForstall
Copy link
Member

My reading of the YAML is that shouldn't happen: it has "trigger: none" and no "pr:" entry. You can go to the AzDO pipeline settings page for your branch:

https://dev.azure.com/dnceng/public/_apps/hub/ms.vss-build-web.ci-designer-hub?pipelineId=1000&nonce=CWUo1CVo5%2F9j6DaKlnWjbw%3D%3D&branch=refs%2Fpull%2F53301%2Fhead

but it just tells you the same thing. Maybe after it gets merged to main the behavior will be different? i.e., AzDO glitch?

@AndyAyersMS
Copy link
Member Author

Thanks for double-checking. I'll submit a trial PR after I merge this just to make sure.

@AndyAyersMS
Copy link
Member Author

FYI those retriggered runs all failed with

.packages/microsoft.dotnet.helix.sdk/6.0.0-beta.21271.3/tools/azure-pipelines/AzurePipelines.MultiQueue.targets(16,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) A call to an Azure DevOps api returned 401, which may indicate a bad 'System.AccessToken' value.

Please Check the 'Make secrets available to builds of forks' in the pipeline pull request validation trigger settings.

@AndyAyersMS
Copy link
Member Author

Remaining legs unrelated, so I'm going to merge this.

@AndyAyersMS AndyAyersMS merged commit de6b2d9 into dotnet:main May 27, 2021
.NET Core CodeGen automation moved this from PGO to Done May 27, 2021
@AndyAyersMS AndyAyersMS deleted the PgoTesting branch May 27, 2021 03:01
@ericstj
Copy link
Member

ericstj commented May 27, 2021

I think this change might be causing all PRs to fail. I haven't seen a single pass of this build definition and it's running on all PRs: https://dev.azure.com/dnceng/public/_build?definitionId=1002&_a=summary

@AndyAyersMS
Copy link
Member Author

Hopefully fixed now, I adjusted the trigger logic.

@ericstj ericstj mentioned this pull request May 27, 2021
Merged
@runfoapp runfoapp bot mentioned this pull request May 27, 2021
Open
@runfoapp runfoapp bot mentioned this pull request May 28, 2021
Closed
@AndyAyersMS AndyAyersMS mentioned this pull request Jun 1, 2021
Closed
54 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees

@AndyAyersMS AndyAyersMS

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
.NET Core CodeGen
Archived in project
.NET Core CodeGen
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndyAyersMS @BruceForstall @ericstj