[interp] Fix loading of ThreadStatic value types #53391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @BrzVlad Issue DetailsFixes #53380
|
|
Would it be possible to add a regression test for this? |
|
@radical We should really add a test for this. I just have no idea where. I assume somewhere in the runtime tests |
|
included runtime test and reverted the fix to see if the test actually does its job |
BrzVlad
force-pushed
the
fix-interp-thread-static-load
branch
from
0a4a9bf
to
1360a35
Compare
BrzVlad
force-pushed
the
fix-interp-thread-static-load
branch
2 times, most recently
from
aa116e6
to
27d4895
Compare
|
@vargaz could you have a look ? |
vargaz
approved these changes
Jun 11, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53380