Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket: don't assign right endpoint until the connect is successful. #53581

Merged
merged 4 commits into from
Jun 5, 2021
Merged

Socket: don't assign right endpoint until the connect is successful. #53581

merged 4 commits into from
Jun 5, 2021

Commits on Jun 2, 2021

  1. Socket: don't assign right endpoint until the connect is successful. 

    'Right endpoint' must match the address family of the Socket or
we can't serialize the LocalEndPoint and RemoteEndPoint.

When multiple connect attempts are made against a DualMode Socket with
both IPv4 and IPv6 addresses, a failed attempt must not set 'right
endpoint'.
    @tmds
    tmds committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    86ab0e2 View commit details
    Browse the repository at this point in the history

  2. SocketTaskExtensionsTest.EnsureMethodsAreCallable: update expected ex… 

    …ceptions
    @tmds
    tmds committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    7a46c27 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. PR feedback

    @tmds
    tmds committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    5167a70 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. EnsureMethodsAreCallable: move ReceiveFromAsync before ConnectAsync t… 

    …o avoid wildcard bind on Windows that leads to a different exception
    @tmds
    tmds committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    78cc5e0 View commit details
    Browse the repository at this point in the history