JIT: fix OSR reporting for special stack slots #53897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revise the reporting of the special stack slots for OSR to be more uniform. * Always record the original method FP-relative offset. * Always apply the same adjustment for original method slosts i the OSR frame * Handle caller-SP relative adjustment in `lvaToCallerSPRelativeOffset` In particular, this fixes dotnet#43534 where we were reporting the wrong caller SP for the profiler exit hook.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
cc @dotnet/jit-contrib OSR stress mode over pri1 passes locally. |
BruceForstall
approved these changes
Jun 8, 2021
src/coreclr/jit/gcencode.cpp
Outdated
| { | ||
| offset = compiler->lvaToCallerSPRelativeOffset(compiler->lvaCachedGenericContextArgOffset(), | ||
| compiler->isFramePointerUsed()); | ||
| // Sanity the offset vs saved patchpoint info. |
There was a problem hiding this comment.
nit: Sanity the => Sanity check the
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise the reporting of the special stack slots for OSR to be more uniform.
lvaToCallerSPRelativeOffsetIn particular, this fixes #43534 where we were reporting the wrong caller SP
for the profiler exit hook.