[wasm][testing] Avoid using crypto in WASM HTTP unit tests #53925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsOn WASM platform POST/PUT tests are blocked by current lack of crypto in WASM.
|
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsOn WASM platform POST/PUT tests are blocked by current lack of crypto in WASM.
|
pavelsavara
force-pushed
the
pr_wasm_network_test_avoid_crypto
branch
from
4d4915e
to
939e7cf
Compare
ManickaP
approved these changes
Jun 10, 2021
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.RemoteServer.cs
Outdated
Show resolved
Hide resolved
...ibraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Handlers/VerifyUploadHandler.cs
Outdated
Show resolved
Hide resolved
7 tasks
radical
reviewed
Jun 10, 2021
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.RemoteServer.cs
Outdated
Show resolved
Hide resolved
...ibraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Handlers/VerifyUploadHandler.cs
Outdated
Show resolved
Hide resolved
radical
approved these changes
Jun 10, 2021
lewing
approved these changes
Jun 10, 2021
voloda
reviewed
Jun 11, 2021
| @@ -358,7 +364,16 @@ public async Task PostAsync_CallMethodTwice_StringContent(Configuration.Http.Rem | |||
|
|
|||
| // Repeat call. | |||
| content = new StringContent(data, Encoding.UTF8); | |||
| content.Headers.ContentMD5 = TestHelper.ComputeMD5Hash(data); | |||
| if (PlatformDetection.IsBrowser) | |||
There was a problem hiding this comment.
Should you have this extracted to a method to reduce copy&paste? :-)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On WASM platform existing POST/PUT tests are blocked by current lack of crypto in WASM.
By skipping content checksum validation in the tests for Browser, we could enable about 130 tests of other HTTP features.
Content-MD5-Skipheader instead ofContent-MD5header from browserContent-MD5-Skipis presentContent-MD5response validationSendAsync_SendRequestUsingMethodToEchoServerWithContent_Successmore granular active issue [wasm][HTTP] TypeError: Failed to execute 'fetch' on 'Window': Request with GET/HEAD method cannot have body #53591SendAsync_GetWithValidHostHeader_Success