Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#54008 Issue Fix #54058

Closed
wants to merge 17 commits into from
Closed

#54008 Issue Fix #54058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a5d9016
#54008 Issue Fix
j0nimost Jun 11, 2021
36c5c65
Added Test
j0nimost Jun 11, 2021
aed8d11
Update Tests
j0nimost Jun 12, 2021
69dcd1a
Update strings resx
j0nimost Jun 13, 2021
4490000
Update Strings.cs.xlf
j0nimost Jun 13, 2021
302a518
Update Strings.de.xlf
j0nimost Jun 13, 2021
d2236a0
Update Strings.es.xlf
j0nimost Jun 13, 2021
8d4758a
Update Strings.fr.xlf
j0nimost Jun 13, 2021
fb5387f
Update Strings.it.xlf
j0nimost Jun 13, 2021
646bdb9
Update Strings.ja.xlf
j0nimost Jun 13, 2021
5fe833a
Update Strings.ko.xlf
j0nimost Jun 13, 2021
f8710ba
Update Strings.pl.xlf
j0nimost Jun 13, 2021
a8f7f15
Update Strings.pt-BR.xlf
j0nimost Jun 13, 2021
6be8d9f
Update Strings.ru.xlf
j0nimost Jun 13, 2021
e551116
Update Strings.tr.xlf
j0nimost Jun 13, 2021
7b9d0b1
Update Strings.zh-Hans.xlf
j0nimost Jun 13, 2021
0966a4c
Update Strings.zh-Hant.xlf
j0nimost Jun 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ public IReadOnlyList<LoggerClass> GetLogClasses(IEnumerable<ClassDeclarationSynt

if (!found)
{
Diag(DiagnosticDescriptors.TemplateHasNoCorrespondingArgument, ma.GetLocation(), t);
Diag(DiagnosticDescriptors.TemplateHasNoCorrespondingArgument, ma.GetLocation(), t.Key);
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
<value>Argument is not referenced from the logging message</value>
</data>
<data name="TemplateHasNoCorrespondingArgumentMessage" xml:space="preserve">
<value>Template {0} is not provided as argument to the logging method</value>
<value>Template '{0}' is not provided as argument to the logging method</value>
</data>
<data name="TemplateHasNoCorrespondingArgumentTitle" xml:space="preserve">
<value>Logging template has no corresponding method argument</value>
Expand Down Expand Up @@ -219,4 +219,4 @@
<data name="GeneratingForMax6ArgumentsMessage" xml:space="preserve">
<value>Generating more than 6 arguments is not supported</value>
</data>
</root>
</root>
6 changes: 3 additions & 3 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentMessage">
<source>Template {0} is not provided as argument to the logging method</source>
<target state="new">Template {0} is not provided as argument to the logging method</target>
<source>Template '{0}' is not provided as argument to the logging method</source>
<target state="new">Template '{0}' is not provided as argument to the logging method</target>
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentTitle">
Expand All @@ -164,4 +164,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>
6 changes: 3 additions & 3 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentMessage">
<source>Template {0} is not provided as argument to the logging method</source>
<target state="new">Template {0} is not provided as argument to the logging method</target>
<source>Template '{0}' is not provided as argument to the logging method</source>
<target state="new">Template '{0}' is not provided as argument to the logging method</target>
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentTitle">
Expand All @@ -164,4 +164,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>
6 changes: 3 additions & 3 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentMessage">
<source>Template {0} is not provided as argument to the logging method</source>
<target state="new">Template {0} is not provided as argument to the logging method</target>
<source>Template '{0}' is not provided as argument to the logging method</source>
<target state="new">Template '{0}' is not provided as argument to the logging method</target>
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentTitle">
Expand All @@ -164,4 +164,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>
6 changes: 3 additions & 3 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentMessage">
<source>Template {0} is not provided as argument to the logging method</source>
<target state="new">Template {0} is not provided as argument to the logging method</target>
<source>Template '{0}' is not provided as argument to the logging method</source>
<target state="new">Template '{0}' is not provided as argument to the logging method</target>
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentTitle">
Expand All @@ -164,4 +164,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>
6 changes: 3 additions & 3 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentMessage">
<source>Template {0} is not provided as argument to the logging method</source>
<target state="new">Template {0} is not provided as argument to the logging method</target>
<source>Template '{0}' is not provided as argument to the logging method</source>
<target state="new">Template '{0}' is not provided as argument to the logging method</target>
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentTitle">
Expand All @@ -164,4 +164,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>
6 changes: 3 additions & 3 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentMessage">
<source>Template {0} is not provided as argument to the logging method</source>
<target state="new">Template {0} is not provided as argument to the logging method</target>
<source>Template '{0}' is not provided as argument to the logging method</source>
<target state="new">Template '{0}' is not provided as argument to the logging method</target>
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentTitle">
Expand All @@ -164,4 +164,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>
6 changes: 3 additions & 3 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentMessage">
<source>Template {0} is not provided as argument to the logging method</source>
<target state="new">Template {0} is not provided as argument to the logging method</target>
<source>Template '{0}' is not provided as argument to the logging method</source>
<target state="new">Template '{0}' is not provided as argument to the logging method</target>
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentTitle">
Expand All @@ -164,4 +164,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>
6 changes: 3 additions & 3 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentMessage">
<source>Template {0} is not provided as argument to the logging method</source>
<target state="new">Template {0} is not provided as argument to the logging method</target>
<source>Template '{0}' is not provided as argument to the logging method</source>
<target state="new">Template '{0}' is not provided as argument to the logging method</target>
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentTitle">
Expand All @@ -164,4 +164,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>
6 changes: 3 additions & 3 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentMessage">
<source>Template {0} is not provided as argument to the logging method</source>
<target state="new">Template {0} is not provided as argument to the logging method</target>
<source>Template '{0}' is not provided as argument to the logging method</source>
<target state="new">Template '{0}' is not provided as argument to the logging method</target>
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentTitle">
Expand All @@ -164,4 +164,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>
6 changes: 3 additions & 3 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentMessage">
<source>Template {0} is not provided as argument to the logging method</source>
<target state="new">Template {0} is not provided as argument to the logging method</target>
<source>Template '{0}' is not provided as argument to the logging method</source>
<target state="new">Template '{0}' is not provided as argument to the logging method</target>
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentTitle">
Expand All @@ -164,4 +164,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>
6 changes: 3 additions & 3 deletions src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentMessage">
<source>Template {0} is not provided as argument to the logging method</source>
<target state="new">Template {0} is not provided as argument to the logging method</target>
<source>Template '{0}' is not provided as argument to the logging method</source>
<target state="new">Template '{0}' is not provided as argument to the logging method</target>
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentTitle">
Expand All @@ -164,4 +164,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>
6 changes: 3 additions & 3 deletions ...libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentMessage">
<source>Template {0} is not provided as argument to the logging method</source>
<target state="new">Template {0} is not provided as argument to the logging method</target>
<source>Template '{0}' is not provided as argument to the logging method</source>
<target state="new">Template '{0}' is not provided as argument to the logging method</target>
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentTitle">
Expand All @@ -164,4 +164,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>
6 changes: 3 additions & 3 deletions ...libraries/Microsoft.Extensions.Logging.Abstractions/gen/Resources/xlf/Strings.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentMessage">
<source>Template {0} is not provided as argument to the logging method</source>
<target state="new">Template {0} is not provided as argument to the logging method</target>
<source>Template '{0}' is not provided as argument to the logging method</source>
<target state="new">Template '{0}' is not provided as argument to the logging method</target>
<note />
</trans-unit>
<trans-unit id="TemplateHasNoCorrespondingArgumentTitle">
Expand All @@ -164,4 +164,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>
1 change: 1 addition & 0 deletions .../tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ partial class C

Assert.Single(diagnostics);
Assert.Equal(DiagnosticDescriptors.TemplateHasNoCorrespondingArgument.Id, diagnostics[0].Id);
Assert.Contains("Template 'foo' is not provided as argument to the logging method", diagnostics[0].GetMessage(), StringComparison.InvariantCulture);
}

[Fact]
Expand Down