Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup rotate patterns #54099

Merged
merged 5 commits into from
Jul 25, 2021
Merged

Cleanup rotate patterns #54099

merged 5 commits into from
Jul 25, 2021

Conversation

huoyaoyuan
Copy link
Member

Did a regex search \(.+<<.+\) \| \(.+>>.+\), and manually recognizes them. Skipped older target frameworks.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Jun 14, 2021

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Did a regex search \(.+<<.+\) \| \(.+>>.+\), and manually recognizes them. Skipped older target frameworks.

Author: huoyaoyuan
Assignees: -
Labels:

area-System.Runtime

Milestone: -

@terrajobst terrajobst added the community-contribution Indicates that the PR has been added by a community member label Jul 19, 2021
@jeffhandley jeffhandley requested a review from jkotas July 23, 2021 21:24
@jeffhandley
Copy link
Member

@jkotas Would you mind reviewing this?

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @huoyaoyuan Thank you!

@jkotas jkotas merged commit d019e70 into dotnet:main Jul 25, 2021
@huoyaoyuan huoyaoyuan deleted the rotate branch July 25, 2021 05:42
@ghost ghost locked as resolved and limited conversation to collaborators Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants