Create a summary Markdown file for all asm diffs #54430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a per-MCH file summary.md file, then accumulate them all into a single overall summary Markdown file, for use in GitHub comments. Uses the existing `jit-analyze --md` functionality. Also, change asm diffs to not report missing data or asm diffs as a replay failure. Finally, don't overwrite superpmi.log files (or the new diff_summary.md files): create new, unique file names for each run.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@kunalspathak @dotnet/jit-contrib PTAL |
kunalspathak
approved these changes
Jun 18, 2021
| # Don't report as replay failure asm diffs (return code 2) or missing data (return code 3). | ||
| # Anything else, such as compilation failure (return code 1, typically a JIT assert) will be | ||
| # reported as a replay failure. | ||
| if return_code != 2 and return_code != 3: |
There was a problem hiding this comment.
This is superpmi replay, so why would it get return_code == 2 (asm diffs failure)?
There was a problem hiding this comment.
This is the asm diffs case (only).
I'll go ahead and add similar "ignore" code to the replay case, but only for missing data.
src/coreclr/scripts/superpmi.py
Outdated
| summary_mch_filename = os.path.basename(summary_mch) # Display just the MCH filename, not the full path | ||
| summary_file = summary_file_info[1] | ||
| with open(summary_file, "r") as read_fh: | ||
| write_fh.write(summary_mch_filename + ":\n\n") |
There was a problem hiding this comment.
Suggested change
| write_fh.write(summary_mch_filename + ":\n\n") | |
| write_fh.write("##" + summary_mch_filename + ":" + os.linesep + os.linesep) |
There was a problem hiding this comment.
According to the docs (https://docs.python.org/3/library/os.html#os.linesep), you shouldn't use os.linesep when writing in text mode: Python auto-converts.
The ## is a good idea.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a per-MCH file summary.md file, then accumulate them all into
a single overall summary Markdown file, for use in GitHub comments.
Uses the existing
jit-analyze --mdfunctionality.Also, change asm diffs to not report missing data or asm diffs as a
replay failure.
Finally, don't overwrite superpmi.log files (or the new diff_summary.md files):
create new, unique file names for each run.