Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-preview6] Remove System.Security.Cryptography.Cng from ASP.NET transport package #54484

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #54428 to release/6.0-preview6

/cc @ViktorHofer @ericstj

Customer Impact

Testing

Risk

@ghost
Copy link

ghost commented Jun 21, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #54428 to release/6.0-preview6

/cc @ViktorHofer @ericstj

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Security

Milestone: -

@ViktorHofer
Copy link
Member

As this is necessary to ship the product (in perspective of aspnetcore) I assume this change is tell-mode only? cc @dougbu

@ericstj
Copy link
Member

ericstj commented Jun 21, 2021

So I just took a look at this and found that it doesn't appear to be blocking. Conflict resolution doesn't drop it, but RAR does:

Encountered conflict between 'Reference:C:\Program Files\dotnet\packs\Microsoft.NETCore.App.Ref\6.0.0-preview.5.21277.4\ref\net6.0\System.Security.Cryptography.Cng.dll' and 'Reference:C:\Program Files\dotnet\packs\Microsoft.AspNetCore.App.Ref\6.0.0-preview.5.21277.4\ref\net6.0\System.Security.Cryptography.Cng.dll'. Could not determine winner due to equal file and assembly versions.
Primary reference "System.Security.Cryptography.Cng, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a".
    Resolved file path is "C:\Program Files\dotnet\packs\Microsoft.AspNetCore.App.Ref\6.0.0-preview.5.21277.4\ref\net6.0\System.Security.Cryptography.Cng.dll".
    Reference found at search path location "{RawFileName}".
    This reference is not "CopyLocal" because at least one source item had "Private" set to "false" and no source items had "Private" set to "true".

So I'm less inclined to take this in P6 unless we have some stronger customer-impact statement. @ViktorHofer @dougbu thoughts?

@dougbu
Copy link
Member

dougbu commented Jun 21, 2021

@ericstj are you saying the duplication is benign and we might as well wait for preview 7 to fix the bug❔ I'd be 🆗 with that as long as the bug doesn't cause new warnings or errors in user scenarios.

@ericstj
Copy link
Member

ericstj commented Jun 21, 2021

Yeah, fix is already in Preview7 and the original reporter indicated he was manually scanning the ref-pack contents. Let's close this since I don't think it meets the bar for Preview6 and there could be fallout (though hopefully not).

@ericstj ericstj closed this Jun 21, 2021
@ViktorHofer
Copy link
Member

@ericstj very minor detail. Please make sure to delete leftover branches like this one as the backport action creates the branch directly in dotnet/runtime which is then fetched by everyone.

@ViktorHofer ViktorHofer deleted the backport/pr-54428-to-release/6.0-preview6 branch June 21, 2021 17:56
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants