[FileStream] add tests for device and UNC paths #54545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
added
the
NO-MERGE
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsContributes to #54495 Does the following:
These tests are going to be failing for now, we need to merge #54483 first
|
stephentoub
reviewed
Jun 23, 2021
src/libraries/System.IO.FileSystem/tests/FileStream/FileStreamConformanceTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 23, 2021
adamsitnik
removed
the
NO-MERGE
|
/azp list |
|
/azp run runtime-libraries-coreclr outerloop-windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries-coreclr outerloop-windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries-coreclr outerloop-windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The CI failures are unrelated (Android and System.ServiceProcess* failures from outerloop) |
stephentoub
reviewed
Jun 23, 2021
src/libraries/System.IO.FileSystem/tests/FileStream/FileStreamConformanceTests.Windows.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jun 23, 2021
src/libraries/System.IO.FileSystem/tests/FileStream/FileStreamConformanceTests.Windows.cs
Outdated
Show resolved
Hide resolved
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Jun 24, 2021
…bugger2 * origin/main: (107 commits) Disable MacCatalyst arm64 PR test runs on staging pipeline (dotnet#54678) [WASM] Fix async/await in config loading (dotnet#54652) Fix for heap_use_after_free flagged by sanitizer (dotnet#54679) [wasm] Bump emscripten to 2.0.23 (dotnet#53603) Fix compiler references when building inside VS (dotnet#54614) process more TLS frames at one when available (dotnet#50815) Add PeriodicTimer (dotnet#53899) UdpClient with span support (dotnet#53429) exclude fragile tests (dotnet#54671) get last error before calling a method that might fail as well (dotnet#54667) [FileStream] add tests for device and UNC paths (dotnet#54545) Fix sporadic double fd close (dotnet#54660) Remove Version.Clone from AssemblyName.Clone (dotnet#54621) [wasm] Enable fixed libraries tests (dotnet#54641) [wasm] Fix blazor/aot builds (dotnet#54651) [mono][wasm] Fix compilation error on wasm (dotnet#54659) Fix telemetry for Socket connects to Dns endpoints (dotnet#54071) [wasm] Build static components; include hot_reload in runtime (dotnet#54568) [wasm][debugger] Reuse debugger-agent on wasm debugger (dotnet#52300) Put Crossgen2 in sync with dotnet#54235 (dotnet#54438) ...
8 tasks
|
/backport to release/6.0-preview6 in case we want it there. |
|
Started backporting to release/6.0-preview6: https://github.com/dotnet/runtime/actions/runs/971756061 |
|
/backport to release/6.0-preview6 |
|
Started backporting to release/6.0-preview6: https://github.com/dotnet/runtime/actions/runs/972063161 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #54495
Does the following:
FileStreamusing handle opened from a path pointing to a named pipe (\\.\pipe\$pipeName)\\.\and\\?\paths that use DeviceID instead of a drive letter (sth like\\.\Volume{724edb31-eaa5-4728-a4e3-f2474fd34ae2}\Users\x\AppData\Local\Temp\y\zinsteadC:\Users\x\AppData\Local\Temp\y\z)\\localhost\$shareName. This requires an Admin privillige and does not work on Nano, which does not provide "netapi32.dll"These tests are going to be failing for now, we need to merge #54483 first