Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-preview6] [wasm] Build static components; include hot_reload in runtime #54622

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 23, 2021

Backport of #54568 to release/6.0-preview6

/cc @lambdageek

Customer Impact

Fixes a regression (compared to .NET 6 Preview 5) that disabled hot reload support for Blazor WebAssembly in .NET 6 Preview 6. Without this PR, dotnet-watch hot reload will not work for Blazor WebAssembly projects. As a workaround, customers could continue to use dotnet build and dotnet run to iterate on their work.

Testing

New functional test in dotnet/runtime that validates that hot reload support is enabled and that applying updates works.

Risk

Low - .NET 6 Preview 5 had working hot reload support - this PR just re-enables a disabled component

@ghost ghost added this to Needs triage in Triage POD for Meta, Reflection, etc Jun 23, 2021
@lambdageek lambdageek added Servicing-consider Issue for next servicing release review arch-wasm WebAssembly architecture area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc and removed area-Meta labels Jun 23, 2021
@ghost
Copy link

ghost commented Jun 23, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #54568 to release/6.0-preview6

/cc @lambdageek

Customer Impact

Fixes a regression (compared to .NET 6 Preview 5) that disabled hot reload support for Blazor WebAssembly in .NET 6 Preview 6. Without this PR, dotnet-watch hot reload will not work for Blazor WebAssembly projects. As a workaround, customers could continue to use dotnet build and dotnet run to iterate on their work.

Testing

New functional test in dotnet/runtime that validates that hot reload support is enabled and that applying updates works.

Risk

Low - .NET 6 Preview 5 had working hot reload support.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, arch-wasm, area-EnC-mono

Milestone: -

@lambdageek
Copy link
Member

The new test is failing because it looks like the wasm configuration changed between preview 6 and main

@lambdageek
Copy link
Member

Updated the test to use the older mechanism. verified locally that the test runs and passes

@lambdageek
Copy link
Member

Servicing-approved by SCarroll over email

@lambdageek lambdageek added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 23, 2021
@lewing
Copy link
Member

lewing commented Jun 24, 2021

@mmitche any timeline on when this can be merged?

@mmitche
Copy link
Member

mmitche commented Jun 24, 2021

@mmitche any timeline on when this can be merged?

Merge when ready.

@steveisok steveisok merged commit 12c92e8 into release/6.0-preview6 Jun 24, 2021
Triage POD for Meta, Reflection, etc automation moved this from Needs triage to Done Jun 24, 2021
@jkotas jkotas deleted the backport/pr-54568-to-release/6.0-preview6 branch July 1, 2021 04:33
@ghost ghost locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-EnC-mono Hot Reload for WebAssembly, iOS/Android, etc Servicing-approved Approved for servicing release
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants