Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add ActivitySource support to DiagnosticsHandler (#54437)" #55006

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

MihaZupan
Copy link
Member

This reverts commit c88da29.

Potentially resolves the System.Net timeout failures tracked by #54778.

Running CI on #54939 ~6 times and saw no Timeout failures yet, while effectively every other PR is affected.

@MihaZupan MihaZupan added this to the 6.0.0 milestone Jul 1, 2021
@MihaZupan MihaZupan requested a review from karelz July 1, 2021 11:07
@MihaZupan MihaZupan self-assigned this Jul 1, 2021
@ghost
Copy link

ghost commented Jul 1, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This reverts commit c88da29.

Potentially resolves the System.Net timeout failures tracked by #54778.

Running CI on #54939 ~6 times and saw no Timeout failures yet, while effectively every other PR is affected.

Author: MihaZupan
Assignees: MihaZupan
Labels:

area-System.Net.Http

Milestone: 6.0.0

@ghost
Copy link

ghost commented Jul 1, 2021

Hello @MihaZupan!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@stephentoub
Copy link
Member

Thank you.

@stephentoub stephentoub merged commit ccc11af into dotnet:main Jul 1, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants