Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime property HOSTFXR_PATH #55369

Merged
merged 5 commits into from
Jul 13, 2021
Merged

Add runtime property HOSTFXR_PATH #55369

merged 5 commits into from
Jul 13, 2021

Conversation

mateoatr
Copy link
Contributor

@mateoatr mateoatr commented Jul 8, 2021

When executing the SDK CLI, set runtime property HOSTFXR_PATH with value equal to the loaded hostfxr path so that the SDK can locate it without having to rely on the heuristics of dlopen/LoadLibrary.

This property is only set when running the muxer and the application is dotnet.dll (that is, this property will only be set if we are about to execute a dotnet cli command).

@ghost
Copy link

ghost commented Jul 8, 2021

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

When executing the SDK CLI, set runtime property HOSTFXR_PATH with value equal to the loaded hostfxr path so that the SDK can locate it without having to rely on the heuristics of dlopen/LoadLibrary.

This property is only set when running the muxer and the application is dotnet.dll (that is, this property will only be set if we are about to execute a dotnet cli command).

Author: mateoatr
Assignees: -
Labels:

area-Host

Milestone: -

@elinor-fung
Copy link
Member

Thoughts on adding a test for checking that HOSTFXR_PATH is set correctly? Maybe something like dummy SDK and mock coreclr, call dotnet such that it should run an SDK command, and check that the new property is logged out as expected.

src/native/corehost/fxr/fx_muxer.cpp Outdated Show resolved Hide resolved
src/installer/tests/HostActivation.Tests/DotNetBuilder.cs Outdated Show resolved Hide resolved
@mateoatr mateoatr closed this Jul 13, 2021
@mateoatr mateoatr reopened this Jul 13, 2021
@mateoatr mateoatr merged commit ae64899 into dotnet:main Jul 13, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants