Simplify PosixSignalRegistration implementation on Unix #55552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
force-pushed
the
psrunixrefactor
branch
from
229cbaf
to
847573c
Compare
tmds
reviewed
Jul 13, 2021
...es/System.Private.CoreLib/src/System/Runtime/InteropServices/PosixSignalRegistration.Unix.cs
Outdated
Show resolved
Hide resolved
Bring it onto the same scheme as the Windows implementation.
stephentoub
force-pushed
the
psrunixrefactor
branch
from
847573c
to
b5a86a1
Compare
|
@stephentoub Can these changes fix #55563 ? |
No |
tmds
reviewed
Jul 13, 2021
...es/System.Private.CoreLib/src/System/Runtime/InteropServices/PosixSignalRegistration.Unix.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring it onto the same scheme as the Windows implementation.
cc: @tmds, @jkotas