Include time taken on DNS queue in events #56208

MihaZupan · 2021-07-23T10:06:39Z

ghost · 2021-07-23T10:06:47Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

MihaZupan · 2021-07-23T13:36:56Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2021-07-23T13:37:10Z

Azure Pipelines successfully started running 1 pipeline(s).

src/libraries/System.Net.NameResolution/tests/FunctionalTests/TelemetryTest.cs

MihaZupan · 2021-07-26T17:21:34Z

@stephentoub did you have other concerns with the PR aside from the EventListener discussion above?

MihaZupan · 2021-07-26T19:03:03Z

Thanks!

MihaZupan added 2 commits July 23, 2021 10:45

Include time taken on DNS queue in events

6ad2cfb

Add test

82ce49d

MihaZupan added the area-System.Net label Jul 23, 2021

MihaZupan added this to the 6.0.0 milestone Jul 23, 2021

MihaZupan requested review from stephentoub and a team July 23, 2021 10:06

MihaZupan added 2 commits July 23, 2021 12:45

Add usings

5725e9d

More usings

eec1b85

stephentoub reviewed Jul 23, 2021

View reviewed changes

src/libraries/System.Net.NameResolution/tests/FunctionalTests/TelemetryTest.cs Outdated Show resolved Hide resolved

Move Assert out of EventListener callback

e7e9ca8

MihaZupan mentioned this pull request Jul 23, 2021

Honor ThrowOnEventWriteErrors for exceptions thrown by EventListeners #56232

Merged

stephentoub approved these changes Jul 26, 2021

View reviewed changes

MihaZupan merged commit 6696065 into dotnet:main Jul 26, 2021

danmoseley mentioned this pull request Jul 27, 2021

improve quic test stability for cancellation #56347

Closed

MihaZupan mentioned this pull request Jul 30, 2021

Account for AddressFamily pairs in NameResolution telemetry #56614

Merged

ghost locked as resolved and limited conversation to collaborators Aug 25, 2021

Provide feedback