Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept empty realm for digest auth (#56369) #56455

Merged
merged 5 commits into from
Aug 3, 2021

Conversation

camillo-toselli
Copy link
Contributor

@camillo-toselli camillo-toselli commented Jul 28, 2021

Fixes #56369

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 28, 2021
@ghost
Copy link

ghost commented Jul 28, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: camillo-toselli
Assignees: -
Labels:

area-System.Net.Http, community-contribution

Milestone: -

@dnfadmin
Copy link

dnfadmin commented Jul 28, 2021

CLA assistant check
All CLA requirements met.

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt wfurt merged commit b0cea40 into dotnet:main Aug 3, 2021
@wfurt
Copy link
Member

wfurt commented Aug 3, 2021

thanks @camillo-toselli

thaystg added a commit to thaystg/runtime that referenced this pull request Aug 3, 2021
# By Camillo Toselli (1) and others
# Via GitHub
* origin/main:
  add RID for Debian 11 (dotnet#56789)
  [wasm] [debugger] Skip thread static field (dotnet#56749)
  Fix timeouts in coreroot_determinism test in GC stress mode (dotnet#56770)
  Use File.OpenHandle in Socket.SendFile directly (dotnet#56777)
  accept empty realm for digest auth (dotnet#56369) (dotnet#56455)

# Conflicts:
#	src/mono/wasm/debugger/DebuggerTestSuite/BreakpointTests.cs
#	src/mono/wasm/debugger/DebuggerTestSuite/GetPropertiesTests.cs
thaystg added a commit to thaystg/runtime that referenced this pull request Aug 4, 2021
…ger_proxy_attribute

* origin/main: (340 commits)
  add RID for Debian 11 (dotnet#56789)
  [wasm] [debugger] Skip thread static field (dotnet#56749)
  Fix timeouts in coreroot_determinism test in GC stress mode (dotnet#56770)
  Use File.OpenHandle in Socket.SendFile directly (dotnet#56777)
  accept empty realm for digest auth (dotnet#56369) (dotnet#56455)
  [wasm][debugger] Create test Inherited Properties (dotnet#56754)
  Mark new test as incompatible with GC Mark4781_1GcStressIncompatible (dotnet#56739)
  Ensure MetadataEnumResult is sufficiently updated by MetaDataImport::Enum (dotnet#56756)
  [mono] Remove gdb xdebug and binary writer support, it hasn't worked in a while. (dotnet#56759)
  Update windows-requirements.md (dotnet#56476)
  Update doc and generic parameter name for JsonValue.GetValue (dotnet#56639)
  [wasm][debugger] Inspect static class (dotnet#56740)
  Fix stack overflow handling issue in GC stress (dotnet#56733)
  Use ReflectionOnly as serialization mode in case dynamic code runtime feature is not supported (dotnet#56604)
  Move Windows Compat pack to NuGet pack task (dotnet#56686)
  Fix build error when building some packages (dotnet#56767)
  Simplify JIT shutdown logic in crossgen2 (dotnet#56687)
  Fix race in crossdac publishing with PGO (dotnet#56762)
  Add DictionaryKeyPolicy support for EnumConverter [dotnet#47765] (dotnet#54429)
  Use ComWrappers in some Marshal unit-tests and update platform metadata  (dotnet#56595)
  ...
bompani pushed a commit to camillo-toselli/runtime that referenced this pull request Aug 11, 2021
* accept empty realm for digest auth (dotnet#56369)

* accept empty realm for digest auth (dotnet#56369)

* accept empty realm for digest auth (dotnet#56369)

* accept empty realm for digest auth (dotnet#56369)

Co-authored-by: Luca Bompani <luca.bompani@unibo.it>
(cherry picked from commit b0cea40)
@karelz karelz added this to the 6.0.0 milestone Aug 17, 2021
bompani pushed a commit to camillo-toselli/runtime that referenced this pull request Sep 21, 2021
* accept empty realm for digest auth (dotnet#56369)

* accept empty realm for digest auth (dotnet#56369)

* accept empty realm for digest auth (dotnet#56369)

* accept empty realm for digest auth (dotnet#56369)

Co-authored-by: Luca Bompani <luca.bompani@unibo.it>
(cherry picked from commit b0cea40)
bompani pushed a commit to camillo-toselli/runtime that referenced this pull request Oct 13, 2021
* accept empty realm for digest auth (dotnet#56369)

* accept empty realm for digest auth (dotnet#56369)

* accept empty realm for digest auth (dotnet#56369)

* accept empty realm for digest auth (dotnet#56369)

Co-authored-by: Luca Bompani <luca.bompani@unibo.it>
(cherry picked from commit b0cea40)
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
@karelz
Copy link
Member

karelz commented Nov 4, 2021

/backport to release/5.0

@dotnet dotnet unlocked this conversation Nov 4, 2021
@karelz
Copy link
Member

karelz commented Nov 4, 2021

/backport to release/5.0

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/1420918007

bompani pushed a commit to camillo-toselli/runtime that referenced this pull request Nov 9, 2021
* accept empty realm for digest auth (dotnet#56369)

* accept empty realm for digest auth (dotnet#56369)

* accept empty realm for digest auth (dotnet#56369)

* accept empty realm for digest auth (dotnet#56369)

Co-authored-by: Luca Bompani <luca.bompani@unibo.it>
(cherry picked from commit b0cea40)
@ghost ghost locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Digest challenge - realm fails with empty string
4 participants