Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on disabled tracing tests #56507

Merged
merged 3 commits into from
Aug 12, 2021

Conversation

josalem
Copy link
Contributor

@josalem josalem commented Jul 29, 2021

Removing all exclusions for tracing/* tests to find which are still failing in CI and which we might be able to turn back on. Not all of them have an associated issue unfortunately, and some of the issues for these test failures have links to builds that have long since been culled by AzDO.

This PR isn't intended to be merged.

I've run the outer loop tests a few times and I haven't seen the listed tests fail. A good number of these tests are simply marked as "needs triage" with no associated GitHub issue. I'm more than happy to turn these back off, but I am hoping to have them on for .net6 in the hopes that we can catch product issues in an LTS branch for servicing over time.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@josalem
Copy link
Contributor Author

josalem commented Jul 29, 2021

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@josalem
Copy link
Contributor Author

josalem commented Jul 29, 2021

/azp run runtime-libraries-coreclr outerloop

@josalem
Copy link
Contributor Author

josalem commented Jul 29, 2021

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@josalem
Copy link
Contributor Author

josalem commented Jul 30, 2021

/azp list

@josalem
Copy link
Contributor Author

josalem commented Jul 30, 2021

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@josalem josalem changed the title [TEST] Turn on disabled tracing tests to see which are still failing Turn on disabled tracing tests Aug 6, 2021
@josalem josalem requested a review from a team August 6, 2021 00:11
@josalem josalem self-assigned this Aug 6, 2021
@josalem josalem added disabled-test The test is disabled in source code against the issue area-Diagnostics-coreclr labels Aug 6, 2021
@ghost
Copy link

ghost commented Aug 6, 2021

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Removing all exclusions for tracing/* tests to find which are still failing in CI and which we might be able to turn back on. Not all of them have an associated issue unfortunately, and some of the issues for these test failures have links to builds that have long since been culled by AzDO.

This PR isn't intended to be merged.

I've run the outer loop tests a few times and I haven't seen the listed tests fail. A good number of these tests are simply marked as "needs triage" with no associated GitHub issue. I'm more than happy to turn these back off, but I am hoping to have them on for .net6 in the hopes that we can catch product issues in an LTS branch for servicing over time.

Author: josalem
Assignees: josalem
Labels:

disabled-test, area-Diagnostics-coreclr

Milestone: -

@josalem josalem added this to the 6.0.0 milestone Aug 6, 2021
@josalem
Copy link
Contributor Author

josalem commented Aug 6, 2021

/azp run runtime-coreclr outerloop

@josalem josalem marked this pull request as ready for review August 6, 2021 00:11
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@josalem
Copy link
Contributor Author

josalem commented Aug 6, 2021

All failures in outerloop appear to be infrastructure (xunit "list modified while enumerating" issue) or R2R failures.

I've yet to see these tests fail in outerloop runs in this PR.

@josalem
Copy link
Contributor Author

josalem commented Aug 6, 2021

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@josalem
Copy link
Contributor Author

josalem commented Aug 6, 2021

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@josalem
Copy link
Contributor Author

josalem commented Aug 10, 2021

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@josalem
Copy link
Contributor Author

josalem commented Aug 10, 2021

Remaining failures are #55657

@josalem josalem merged commit b2714bc into dotnet:main Aug 12, 2021
@josalem josalem deleted the dev/josalem/tracing-tests-test branch August 12, 2021 22:16
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Diagnostics-coreclr disabled-test The test is disabled in source code against the issue
Projects
.NET Core Diagnostics
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants