Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check _abortException before checking _shutdown flag #56552

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Check _abortException before checking _shutdown flag #56552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c83ff1e
Replaces await with Parallel.Invoke
alnikola Jul 28, 2021
7cabc7e
Check _abortException before checking _shutdown flag
alnikola Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Connection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1492,6 +1492,11 @@ private void AddStream(Http2Stream http2Stream)
Shutdown();
}

if (_abortException is not null)
{
throw GetRequestAbortedException(_abortException);
}

if (_shutdown)
{
// The connection has shut down. Throw a retryable exception so that this request will be handled on another connection.
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,6 @@ public async Task Http2_ServerSendsValidSettingsValues_Success()
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/1581")]
[ConditionalTheory(nameof(SupportsAlpn))]
[InlineData(SettingId.MaxFrameSize, 16383)]
[InlineData(SettingId.MaxFrameSize, 162777216)]
Expand Down