Do not run crossgen2 under GC stress in tests #56949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonLapounov
commented
Aug 6, 2021
| @@ -4,8 +4,6 @@ | |||
| <CLRTestKind>BuildAndRun</CLRTestKind> | |||
| <CLRTestPriority>0</CLRTestPriority> | |||
| <CLRTestTargetUnsupported Condition="'$(RuntimeFlavor)' != 'coreclr'">true</CLRTestTargetUnsupported> | |||
| <!-- See https://github.com/dotnet/runtime/issues/50704 --> | |||
| <GCStressIncompatible>true</GCStressIncompatible> | |||
There was a problem hiding this comment.
This test should pass after #56770 disabled propagating COMPlus_GCStress environment variable to crossgen2.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unset
COMPlus_GCName,COMPlus_GCStress,COMPlus_HeapVerify, andCOMPlus_ReadyToRunenvironment variables before runningcrossgen2formainv1,mainv2, andBasicTestWithMcjtests as we already do for other tests. Usesetlocal/endlocalandexport -n/exportcommands to simplify saving and restoring original variable values.Fixes #54203. @dotnet/crossgen-contrib