[release/6.0] Adding null check to avoid abort when invalid IL is encountered #57731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
When a callvirt instruction is encountered on a static method, there is a hard abort/crash. This commit avoids the problem.
github-actions
bot
requested review from
imhameed,
lambdageek,
SamMonoRT and
vargaz
as code owners
lambdageek
approved these changes
Aug 19, 2021
|
cc @marek-safar for M2 approval |
jeffschwMSFT
approved these changes
Aug 19, 2021
akoeplinger
changed the title
|
This isn't critical for rc1 so I retargeted to release/6.0 for RC2. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #57522 to release/6.0
/cc @akoeplinger @bholmes
Customer Impact
When a callvirt instruction is encountered on a static method, there is a hard abort/crash. This commit avoids the problem.
Testing
Tested with sample program in #57522 (comment)
Risk
Minimal, it just adds a null check.