Only report live ranges for allocated variables #57843
Conversation
With dead code it is possible that certain IL locals are never allocated, but still live in other blocks. In this case there is no information to report to the VM. Fixes dotnet#57767
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsWith dead code it is possible that certain IL locals are never Fixes #57767 In the previous behavior we would report back BAD_STK_OFFS to the VM for these IL variables. cc @dotnet/jit-contrib
|
|
I checked the runtime and it does not look like this corrupted data has any ill effects in non-debugger parts. I then tried debugging the optimized code with this problem and found no issues, potentially because the IP is never within the buggy region, so this seems very difficult to hit. Don't think this needs to be backported. |
|
ping @EgorBo @dotnet/jit-contrib |
With dead code it is possible that certain IL locals are never
allocated, but still live in other blocks. In this case there is no
information to report to the VM.
Fixes #57767
In the previous behavior we would report back BAD_STK_OFFS to the VM for these IL variables.
I'm not totally sure what effect that has on the VM/debugger. But given that this data makes it pretty far into the runtime, and the fact that we have quite a bit of this kind of dead code that makes it to codegen #57767 (comment)), this targeted fix might be one to backport. Any thoughts?
cc @dotnet/jit-contrib