Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate System.IO.FileSystem for nullable #590

Merged
merged 8 commits into from
Dec 11, 2019
Merged

Annotate System.IO.FileSystem for nullable #590

merged 8 commits into from
Dec 11, 2019

Conversation

buyaa-n
Copy link
Member

@buyaa-n buyaa-n commented Dec 5, 2019

Reopening #531 as that PR was created from master branch
CC @stephentoub @safern

@buyaa-n buyaa-n mentioned this pull request Dec 5, 2019
Closed
@buyaa-n
Copy link
Member Author

buyaa-n commented Dec 11, 2019

/azp run runtime-libraries

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@buyaa-n
Copy link
Member Author

buyaa-n commented Dec 11, 2019

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@buyaa-n
Copy link
Member Author

buyaa-n commented Dec 11, 2019

Seems runtime builds are not working properly and not related to the PR. As libraries build passed gonna merge

@buyaa-n buyaa-n merged commit 96d9a47 into dotnet:master Dec 11, 2019
@buyaa-n buyaa-n deleted the io_filesystem branch February 13, 2020 01:33
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
MichalStrehovsky pushed a commit to MichalStrehovsky/runtime that referenced this pull request Mar 25, 2021
@jkotas
Add check for .NET 5 SDK, update NativeLibrary sample instructions (d…
0a644c7 
…otnet#601)

Fixes dotnet#590
Fixes dotnet#589
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@safern safern safern approved these changes

@carlossanlop carlossanlop Awaiting requested review from carlossanlop

@JeremyKuhne JeremyKuhne Awaiting requested review from JeremyKuhne

Assignees
No one assigned
Labels
area-System.IO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@buyaa-n @stephentoub @safern @Dotnet-GitSync-Bot