Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File.Unix: save a syscall on the File.{Write*,Append*} methods. #59247

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

tmds
Copy link
Member

@tmds tmds commented Sep 17, 2021

FileOptions.SequentialScan tunes the kernel read ahead. Since we're writing
the whole file it doesn't bring anything, and it costs us a syscall on Unix.

@adamsitnik @stephentoub ptal.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 17, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.IO and removed community-contribution Indicates that the PR has been added by a community member labels Sep 17, 2021
@ghost
Copy link

ghost commented Sep 17, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

FileOptions.SequentialScan tunes the kernel read ahead. Since we're writing
the whole file it doesn't bring anything, and it costs us a syscall on Unix.

@adamsitnik @stephentoub ptal.

Author: tmds
Assignees: -
Labels:

area-System.IO

Milestone: -

FileOptions.SequentialScan tunes the kernel read ahead. Since we're writing
the whole file it doesn't bring anything, and it costs us a syscall on Unix.
@tmds tmds changed the title File.Unix: save a syscall on the File.{Read*,Write*} methods. File.Unix: save a syscall on the File.{Write*,Append*} methods. Sep 17, 2021
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @tmds!

@adamsitnik adamsitnik added this to the 7.0.0 milestone Sep 17, 2021
@adamsitnik adamsitnik merged commit 6081289 into dotnet:main Sep 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants