Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.VisualBasic.Core.Tests fail tests with NaN conversion #59321

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Microsoft.VisualBasic.Core.Tests fail tests with NaN conversion #59321

merged 2 commits into from
Sep 20, 2021

Conversation

AlexRadch
Copy link
Contributor

When the current culture is not English, then Microsoft.VisualBasic.Core.Tests fail tests with NaN conversion.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 19, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Microsoft.VisualBasic and removed community-contribution Indicates that the PR has been added by a community member labels Sep 19, 2021
@ghost
Copy link

ghost commented Sep 19, 2021

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

Issue Details

When the current culture is not English, then Microsoft.VisualBasic.Core.Tests fail tests with NaN conversion.

Author: AlexRadch
Assignees: -
Labels:

area-Microsoft.VisualBasic

Milestone: -

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@danmoseley
Copy link
Member

@karelz there are several networking timeouts. are these just random endpoint issues ? eg

❌ System.Net.Sockets.Tests.SendPacketsAsync.SendPacketsElement_FileStreamLargeOffset_Throws [Details] [History] [Artifacts]
Exception Message
Timed out
Expected: True
Actual:   False
CallStack
   at System.Net.Sockets.Tests.SendPacketsAsync.SendPackets(SendPacketsElement[] elements, SocketError expectedResult, Int32 bytesExpected, Byte[] contentExpected) in /_/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendPacketsAsync.cs:line 693
   at System.Net.Sockets.Tests.SendPacketsAsync.SendPackets(SendPacketsElement element, SocketError expectedResult, Int32 bytesExpected) in /_/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendPacketsAsync.cs:line 670
   at System.Net.Sockets.Tests.SendPacketsAsync.SendPacketsElement_FileStreamLargeOffset_Throws() in /_/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendPacketsAsync.cs:line 535

@danmoseley
Copy link
Member

@danmoseley danmoseley merged commit fd5b60f into dotnet:main Sep 20, 2021
@AlexRadch AlexRadch deleted the VisualBasicCoreTestsFailedGlobalization branch September 21, 2021 02:52
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants