Skip ExportPkcs7_Empty test on mobile platforms #59626
Conversation
The test made it through and was failing on CI. PKCS#7 export is not supported on mobile platforms.
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThe test made it through and was failing on CI. PKCS#7 export is not supported on mobile platforms.
|
| @@ -154,7 +154,6 @@ int32_t AndroidCryptoNative_X509ExportPkcs7(jobject* /*X509Certificate[]*/ certs | |||
| int32_t* outLen) | |||
| { | |||
| abort_if_invalid_pointer_argument (certs); | |||
| abort_if_negative_integer_argument (certsLen); | |||
There was a problem hiding this comment.
This seems distinct from disabling a test... should it really be part of the same change?
There was a problem hiding this comment.
I can throw up a separate PR. I originally thought it was going to skip android, but realized it was failing for a completely different reason.
There was a problem hiding this comment.
Ah, OK, so this is fixing Android and disabling it on iOS/tvOS.
Separate changes would be more ideal... but why respin CI?
|
Opened #59678 for the test failures. |
ghost
locked as resolved and limited conversation to collaborators
The test made it through and was failing on CI. PKCS#7 export is not supported on mobile platforms.